[wasm] Clean up callback triggering

A minor refactoring to the logic for triggering callbacks:
1. If compilation failed, do only trigger the kFailedCompilation event.
2. Use the TriggerCallbacks method also for triggering the
  kFailedCompilation event.

R=thibaudm@chromium.org

Bug: chromium:1101340
Change-Id: I3446d708d28068448e6eca3e637c9af673f5311d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332171Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69215}

src/wasm/module-compiler.cc

@@ -2849,6 +2849,12 @@ void CompilationStateImpl::TriggerCallbacks(
     }
   }
 
+  if (compile_failed_.load(std::memory_order_relaxed)) {
+    // *Only* trigger the "failed" event.
+    triggered_events =
+        base::EnumSet<CompilationEvent>({CompilationEvent::kFailedCompilation});
+  }
+
   if (triggered_events.empty()) return;
 
   // Don't trigger past events again.
@@ -2858,7 +2864,9 @@ void CompilationStateImpl::TriggerCallbacks(
       triggered_events - CompilationEvent::kFinishedRecompilation;
 
   for (auto event :
-       {std::make_pair(CompilationEvent::kFinishedBaselineCompilation,
+       {std::make_pair(CompilationEvent::kFailedCompilation,
+                       "wasm.CompilationFailed"),
+        std::make_pair(CompilationEvent::kFinishedBaselineCompilation,
                        "wasm.BaselineFinished"),
         std::make_pair(CompilationEvent::kFinishedTopTierCompilation,
                        "wasm.TopTierFinished"),
@@ -2957,11 +2965,7 @@ void CompilationStateImpl::SetError() {
   }
 
   base::MutexGuard callbacks_guard(&callbacks_mutex_);
-  for (auto& callback : callbacks_) {
-    callback(CompilationEvent::kFailedCompilation);
-  }
-  // No more callbacks after an error.
-  callbacks_.clear();
+  TriggerCallbacks();
 }
 
 namespace {