Commit d995d4bd authored by svenpanne's avatar svenpanne Committed by Commit bot

[TurboFan] Fixed handling of CompareIC return type.

Although all this code might be moved around later, it's a good idea
to unhackify it now. :-)

Review URL: https://codereview.chromium.org/1067193004

Cr-Commit-Position: refs/heads/master@{#27672}
parent af293729
...@@ -122,7 +122,7 @@ void JSGenericLowering::ReplaceWithCompareIC(Node* node, Token::Value token) { ...@@ -122,7 +122,7 @@ void JSGenericLowering::ReplaceWithCompareIC(Node* node, Token::Value token) {
CallDescriptor* desc_compare = Linkage::GetStubCallDescriptor( CallDescriptor* desc_compare = Linkage::GetStubCallDescriptor(
isolate(), zone(), callable.descriptor(), 0, isolate(), zone(), callable.descriptor(), 0,
CallDescriptor::kPatchableCallSiteWithNop | FlagsForNode(node), CallDescriptor::kPatchableCallSiteWithNop | FlagsForNode(node),
Operator::kNoProperties, kMachInt32); Operator::kNoProperties, kMachIntPtr);
// Create a new call node asking a CompareIC for help. // Create a new call node asking a CompareIC for help.
NodeVector inputs(zone()); NodeVector inputs(zone());
...@@ -149,8 +149,6 @@ void JSGenericLowering::ReplaceWithCompareIC(Node* node, Token::Value token) { ...@@ -149,8 +149,6 @@ void JSGenericLowering::ReplaceWithCompareIC(Node* node, Token::Value token) {
Node* compare = Node* compare =
graph()->NewNode(common()->Call(desc_compare), graph()->NewNode(common()->Call(desc_compare),
static_cast<int>(inputs.size()), &inputs.front()); static_cast<int>(inputs.size()), &inputs.front());
NodeProperties::SetBounds(
compare, Bounds(Type::None(zone()), Type::UntaggedSigned(zone())));
// Decide how the return value from the above CompareIC can be converted into // Decide how the return value from the above CompareIC can be converted into
// a JavaScript boolean oddball depending on the given token. // a JavaScript boolean oddball depending on the given token.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment