TurboFan: Introduce TaggedSigned and TaggedPointer representations.

These new representations aren't used yet. BUG= Review-Url: https://codereview.chromium.org/2216383002 Cr-Commit-Position: refs/heads/master@{#38657}

TurboFan: Introduce TaggedSigned and TaggedPointer representations.
These new representations aren't used yet. BUG= Review-Url: https://codereview.chromium.org/2216383002 Cr-Commit-Position: refs/heads/master@{#38657}
d941b52d · mvstanton · Commit bot · 4872bc81 · d941b52d · d941b52d
Commit d941b52d authored Aug 16, 2016 by mvstanton Committed by Commit bot Aug 16, 2016
15 changed files
--- a/src/compiler/arm/instruction-selector-arm.cc
+++ b/src/compiler/arm/instruction-selector-arm.cc
@@ -402,6 +402,8 @@ void InstructionSelector::VisitLoad(Node* node) {
    case MachineRepresentation::kWord16:
      opcode = load_rep.IsUnsigned() ? kArmLdrh : kArmLdrsh;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord32:
      opcode = kArmLdr;
@@ -481,6 +483,8 @@ void InstructionSelector::VisitStore(Node* node) {
      case MachineRepresentation::kWord16:
        opcode = kArmStrh;
        break;
+      case MachineRepresentation::kTaggedSigned:   // Fall through.
+      case MachineRepresentation::kTaggedPointer:  // Fall through.
      case MachineRepresentation::kTagged:  // Fall through.
      case MachineRepresentation::kWord32:
        opcode = kArmStr;
@@ -640,6 +644,8 @@ void InstructionSelector::VisitCheckedLoad(Node* node) {
      opcode = kCheckedLoadFloat64;
      break;
    case MachineRepresentation::kBit:      // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:   // Fall through.
    case MachineRepresentation::kWord64:   // Fall through.
    case MachineRepresentation::kSimd128:  // Fall through.
@@ -682,6 +688,8 @@ void InstructionSelector::VisitCheckedStore(Node* node) {
      opcode = kCheckedStoreFloat64;
      break;
    case MachineRepresentation::kBit:      // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:   // Fall through.
    case MachineRepresentation::kWord64:   // Fall through.
    case MachineRepresentation::kSimd128:  // Fall through.

--- a/src/compiler/arm64/instruction-selector-arm64.cc
+++ b/src/compiler/arm64/instruction-selector-arm64.cc
@@ -591,6 +591,8 @@ void InstructionSelector::VisitLoad(Node* node) {
      opcode = kArm64LdrW;
      immediate_mode = kLoadStoreImm32;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord64:
      opcode = kArm64Ldr;
@@ -681,6 +683,8 @@ void InstructionSelector::VisitStore(Node* node) {
        opcode = kArm64StrW;
        immediate_mode = kLoadStoreImm32;
        break;
+      case MachineRepresentation::kTaggedSigned:   // Fall through.
+      case MachineRepresentation::kTaggedPointer:  // Fall through.
      case MachineRepresentation::kTagged:  // Fall through.
      case MachineRepresentation::kWord64:
        opcode = kArm64Str;
@@ -746,6 +750,8 @@ void InstructionSelector::VisitCheckedLoad(Node* node) {
      opcode = kCheckedLoadFloat64;
      break;
    case MachineRepresentation::kBit:      // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:   // Fall through.
    case MachineRepresentation::kSimd128:  // Fall through.
    case MachineRepresentation::kNone:
@@ -796,6 +802,8 @@ void InstructionSelector::VisitCheckedStore(Node* node) {
      opcode = kCheckedStoreFloat64;
      break;
    case MachineRepresentation::kBit:      // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:   // Fall through.
    case MachineRepresentation::kSimd128:  // Fall through.
    case MachineRepresentation::kNone:

--- a/src/compiler/ia32/instruction-selector-ia32.cc
+++ b/src/compiler/ia32/instruction-selector-ia32.cc
@@ -226,7 +226,9 @@ void InstructionSelector::VisitLoad(Node* node) {
    case MachineRepresentation::kWord16:
      opcode = load_rep.IsSigned() ? kIA32Movsxwl : kIA32Movzxwl;
      break;
-    case MachineRepresentation::kTagged:  // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
+    case MachineRepresentation::kTagged:         // Fall through.
    case MachineRepresentation::kWord32:
      opcode = kIA32Movl;
      break;
@@ -310,7 +312,9 @@ void InstructionSelector::VisitStore(Node* node) {
      case MachineRepresentation::kWord16:
        opcode = kIA32Movw;
        break;
-      case MachineRepresentation::kTagged:  // Fall through.
+      case MachineRepresentation::kTaggedSigned:   // Fall through.
+      case MachineRepresentation::kTaggedPointer:  // Fall through.
+      case MachineRepresentation::kTagged:         // Fall through.
      case MachineRepresentation::kWord32:
        opcode = kIA32Movl;
        break;
@@ -372,10 +376,12 @@ void InstructionSelector::VisitCheckedLoad(Node* node) {
    case MachineRepresentation::kFloat64:
      opcode = kCheckedLoadFloat64;
      break;
-    case MachineRepresentation::kBit:      // Fall through.
-    case MachineRepresentation::kTagged:   // Fall through.
-    case MachineRepresentation::kWord64:   // Fall through.
-    case MachineRepresentation::kSimd128:  // Fall through.
+    case MachineRepresentation::kBit:            // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
+    case MachineRepresentation::kTagged:         // Fall through.
+    case MachineRepresentation::kWord64:         // Fall through.
+    case MachineRepresentation::kSimd128:        // Fall through.
    case MachineRepresentation::kNone:
      UNREACHABLE();
      return;
@@ -419,10 +425,12 @@ void InstructionSelector::VisitCheckedStore(Node* node) {
    case MachineRepresentation::kFloat64:
      opcode = kCheckedStoreFloat64;
      break;
-    case MachineRepresentation::kBit:      // Fall through.
-    case MachineRepresentation::kTagged:   // Fall through.
-    case MachineRepresentation::kWord64:   // Fall through.
-    case MachineRepresentation::kSimd128:  // Fall through.
+    case MachineRepresentation::kBit:            // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
+    case MachineRepresentation::kTagged:         // Fall through.
+    case MachineRepresentation::kWord64:         // Fall through.
+    case MachineRepresentation::kSimd128:        // Fall through.
    case MachineRepresentation::kNone:
      UNREACHABLE();
      return;

--- a/src/compiler/instruction.cc
+++ b/src/compiler/instruction.cc
@@ -180,6 +180,12 @@ std::ostream& operator<<(std::ostream& os,
        case MachineRepresentation::kSimd128:
          os << "|s128";
          break;
+        case MachineRepresentation::kTaggedSigned:
+          os << "|ts";
+          break;
+        case MachineRepresentation::kTaggedPointer:
+          os << "|tp";
+          break;
        case MachineRepresentation::kTagged:
          os << "|t";
          break;
@@ -795,6 +801,8 @@ static MachineRepresentation FilterRepresentation(MachineRepresentation rep) {
    case MachineRepresentation::kFloat32:
    case MachineRepresentation::kFloat64:
    case MachineRepresentation::kSimd128:
+    case MachineRepresentation::kTaggedSigned:
+    case MachineRepresentation::kTaggedPointer:
    case MachineRepresentation::kTagged:
      return rep;
    case MachineRepresentation::kNone:

--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -466,6 +466,8 @@ class LocationOperand : public InstructionOperand {
      case MachineRepresentation::kFloat32:
      case MachineRepresentation::kFloat64:
      case MachineRepresentation::kSimd128:
+      case MachineRepresentation::kTaggedSigned:
+      case MachineRepresentation::kTaggedPointer:
      case MachineRepresentation::kTagged:
        return true;
      case MachineRepresentation::kBit:

--- a/src/compiler/load-elimination.cc
+++ b/src/compiler/load-elimination.cc
@@ -514,6 +514,8 @@ Reduction LoadElimination::ReduceStoreElement(Node* node) {
      break;
    case MachineRepresentation::kFloat64:
    case MachineRepresentation::kSimd128:
+    case MachineRepresentation::kTaggedSigned:
+    case MachineRepresentation::kTaggedPointer:
    case MachineRepresentation::kTagged:
      state = state->AddElement(object, index, new_value, zone());
      break;
@@ -688,6 +690,9 @@ int LoadElimination::FieldIndexOf(FieldAccess const& access) {
      return -1;  // Currently untracked.
    case MachineRepresentation::kFloat64:
    case MachineRepresentation::kSimd128:
+      return -1;  // Currently untracked.
+    case MachineRepresentation::kTaggedSigned:
+    case MachineRepresentation::kTaggedPointer:
    case MachineRepresentation::kTagged:
      // TODO(bmeurer): Check that we never do overlapping load/stores of
      // individual parts of Float64/Simd128 values.

--- a/src/compiler/machine-operator.cc
+++ b/src/compiler/machine-operator.cc
@@ -436,6 +436,8 @@ MachineRepresentation AtomicStoreRepresentationOf(Operator const* op) {
  V(kWord16)                           \
  V(kWord32)                           \
  V(kWord64)                           \
+  V(kTaggedSigned)                     \
+  V(kTaggedPointer)                    \
  V(kTagged)

 #define ATOMIC_TYPE_LIST(V) \

--- a/src/compiler/mips/instruction-selector-mips.cc
+++ b/src/compiler/mips/instruction-selector-mips.cc
@@ -159,6 +159,8 @@ void InstructionSelector::VisitLoad(Node* node) {
    case MachineRepresentation::kWord16:
      opcode = load_rep.IsUnsigned() ? kMipsLhu : kMipsLh;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord32:
      opcode = kMipsLw;
@@ -238,6 +240,8 @@ void InstructionSelector::VisitStore(Node* node) {
      case MachineRepresentation::kWord16:
        opcode = kMipsSh;
        break;
+      case MachineRepresentation::kTaggedSigned:   // Fall through.
+      case MachineRepresentation::kTaggedPointer:  // Fall through.
      case MachineRepresentation::kTagged:  // Fall through.
      case MachineRepresentation::kWord32:
        opcode = kMipsSw;
@@ -953,6 +957,8 @@ void InstructionSelector::VisitUnalignedLoad(Node* node) {
    case MachineRepresentation::kWord16:
      opcode = load_rep.IsUnsigned() ? kMipsUlhu : kMipsUlh;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord32:
      opcode = kMipsUlw;
@@ -1007,6 +1013,8 @@ void InstructionSelector::VisitUnalignedStore(Node* node) {
    case MachineRepresentation::kWord16:
      opcode = kMipsUsh;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord32:
      opcode = kMipsUsw;
@@ -1055,6 +1063,8 @@ void InstructionSelector::VisitCheckedLoad(Node* node) {
      opcode = kCheckedLoadFloat64;
      break;
    case MachineRepresentation::kBit:      // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:   // Fall through.
    case MachineRepresentation::kWord64:   // Fall through.
    case MachineRepresentation::kSimd128:  // Fall through.

--- a/src/compiler/mips64/instruction-selector-mips64.cc
+++ b/src/compiler/mips64/instruction-selector-mips64.cc
@@ -167,6 +167,8 @@ void InstructionSelector::VisitLoad(Node* node) {
    case MachineRepresentation::kWord32:
      opcode = load_rep.IsUnsigned() ? kMips64Lwu : kMips64Lw;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord64:
      opcode = kMips64Ld;
@@ -248,6 +250,8 @@ void InstructionSelector::VisitStore(Node* node) {
      case MachineRepresentation::kWord32:
        opcode = kMips64Sw;
        break;
+      case MachineRepresentation::kTaggedSigned:   // Fall through.
+      case MachineRepresentation::kTaggedPointer:  // Fall through.
      case MachineRepresentation::kTagged:  // Fall through.
      case MachineRepresentation::kWord64:
        opcode = kMips64Sd;
@@ -1365,6 +1369,8 @@ void InstructionSelector::VisitUnalignedLoad(Node* node) {
    case MachineRepresentation::kWord32:
      opcode = load_rep.IsUnsigned() ? kMips64Ulwu : kMips64Ulw;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord64:
      opcode = kMips64Uld;
@@ -1413,6 +1419,8 @@ void InstructionSelector::VisitUnalignedStore(Node* node) {
    case MachineRepresentation::kWord32:
      opcode = kMips64Usw;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord64:
      opcode = kMips64Usd;
@@ -1463,6 +1471,8 @@ void InstructionSelector::VisitCheckedLoad(Node* node) {
      opcode = kCheckedLoadFloat64;
      break;
    case MachineRepresentation::kBit:
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:
    case MachineRepresentation::kSimd128:
    case MachineRepresentation::kNone:
@@ -1513,6 +1523,8 @@ void InstructionSelector::VisitCheckedStore(Node* node) {
      opcode = kCheckedStoreFloat64;
      break;
    case MachineRepresentation::kBit:
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:
    case MachineRepresentation::kSimd128:
    case MachineRepresentation::kNone:

--- a/src/compiler/register-allocator.cc
+++ b/src/compiler/register-allocator.cc
@@ -71,6 +71,8 @@ int GetByteWidth(MachineRepresentation rep) {
    case MachineRepresentation::kWord8:
    case MachineRepresentation::kWord16:
    case MachineRepresentation::kWord32:
+    case MachineRepresentation::kTaggedSigned:
+    case MachineRepresentation::kTaggedPointer:
    case MachineRepresentation::kTagged:
      return kPointerSize;
    case MachineRepresentation::kFloat32:

--- a/src/compiler/representation-change.cc
+++ b/src/compiler/representation-change.cc
@@ -141,6 +141,8 @@ Node* RepresentationChanger::GetRepresentationFor(
  }

  switch (use_info.representation()) {
+    case MachineRepresentation::kTaggedSigned:
+    case MachineRepresentation::kTaggedPointer:
    case MachineRepresentation::kTagged:
      DCHECK(use_info.type_check() == TypeCheckKind::kNone);
      return GetTaggedRepresentationFor(node, output_rep, output_type);

--- a/src/compiler/simplified-lowering.cc
+++ b/src/compiler/simplified-lowering.cc
@@ -120,6 +120,8 @@ UseInfo CheckedUseInfoAsFloat64FromHint(NumberOperationHint hint) {

 UseInfo TruncatingUseInfoFromRepresentation(MachineRepresentation rep) {
  switch (rep) {
+    case MachineRepresentation::kTaggedSigned:
+    case MachineRepresentation::kTaggedPointer:
    case MachineRepresentation::kTagged:
      return UseInfo::AnyTagged();
    case MachineRepresentation::kFloat64:

--- a/src/compiler/x64/instruction-selector-x64.cc
+++ b/src/compiler/x64/instruction-selector-x64.cc
@@ -169,6 +169,8 @@ void InstructionSelector::VisitLoad(Node* node) {
    case MachineRepresentation::kWord32:
      opcode = kX64Movl;
      break;
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:  // Fall through.
    case MachineRepresentation::kWord64:
      opcode = kX64Movq;
@@ -254,6 +256,8 @@ void InstructionSelector::VisitStore(Node* node) {
      case MachineRepresentation::kWord32:
        opcode = kX64Movl;
        break;
+      case MachineRepresentation::kTaggedSigned:   // Fall through.
+      case MachineRepresentation::kTaggedPointer:  // Fall through.
      case MachineRepresentation::kTagged:  // Fall through.
      case MachineRepresentation::kWord64:
        opcode = kX64Movq;
@@ -311,6 +315,8 @@ void InstructionSelector::VisitCheckedLoad(Node* node) {
      break;
    case MachineRepresentation::kBit:      // Fall through.
    case MachineRepresentation::kSimd128:  // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:   // Fall through.
    case MachineRepresentation::kNone:
      UNREACHABLE();
@@ -364,6 +370,8 @@ void InstructionSelector::VisitCheckedStore(Node* node) {
      break;
    case MachineRepresentation::kBit:      // Fall through.
    case MachineRepresentation::kSimd128:  // Fall through.
+    case MachineRepresentation::kTaggedSigned:   // Fall through.
+    case MachineRepresentation::kTaggedPointer:  // Fall through.
    case MachineRepresentation::kTagged:   // Fall through.
    case MachineRepresentation::kNone:
      UNREACHABLE();

--- a/src/machine-type.cc
+++ b/src/machine-type.cc
@@ -32,6 +32,10 @@ const char* MachineReprToString(MachineRepresentation rep) {
      return "kRepFloat64";
    case MachineRepresentation::kSimd128:
      return "kRepSimd128";
+    case MachineRepresentation::kTaggedSigned:
+      return "kRepTaggedSigned";
+    case MachineRepresentation::kTaggedPointer:
+      return "kRepTaggedPointer";
    case MachineRepresentation::kTagged:
      return "kRepTagged";
  }

--- a/src/machine-type.h
+++ b/src/machine-type.h
@@ -25,6 +25,8 @@ enum class MachineRepresentation : uint8_t {
  kFloat32,
  kFloat64,  // must follow kFloat32
  kSimd128,  // must follow kFloat64
+  kTaggedSigned,
+  kTaggedPointer,
  kTagged
 };

@@ -228,6 +230,8 @@ inline int ElementSizeLog2Of(MachineRepresentation rep) {
      return 3;
    case MachineRepresentation::kSimd128:
      return 4;
+    case MachineRepresentation::kTaggedSigned:
+    case MachineRepresentation::kTaggedPointer:
    case MachineRepresentation::kTagged:
      return kPointerSizeLog2;
    default: