Commit d915b902 authored by Benedikt Meurer's avatar Benedikt Meurer Committed by V8 LUCI CQ

[inspector] Remove unused `V8StackTrace::buildInspectorObject()`.

This is an unused overload, which doesn't add any value to keep around.

Bug: none
Change-Id: I6e004e28f6ec8d4c8de87a1e86d331a624694659
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297896
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78052}
parent b1a6f769
...@@ -118,8 +118,6 @@ class V8_EXPORT V8StackTrace { ...@@ -118,8 +118,6 @@ class V8_EXPORT V8StackTrace {
virtual ~V8StackTrace() = default; virtual ~V8StackTrace() = default;
virtual std::unique_ptr<protocol::Runtime::API::StackTrace> virtual std::unique_ptr<protocol::Runtime::API::StackTrace>
buildInspectorObject() const = 0;
virtual std::unique_ptr<protocol::Runtime::API::StackTrace>
buildInspectorObject(int maxAsyncDepth) const = 0; buildInspectorObject(int maxAsyncDepth) const = 0;
virtual std::unique_ptr<StringBuffer> toString() const = 0; virtual std::unique_ptr<StringBuffer> toString() const = 0;
......
...@@ -330,11 +330,6 @@ V8StackTraceImpl::buildInspectorObjectImpl(V8Debugger* debugger, ...@@ -330,11 +330,6 @@ V8StackTraceImpl::buildInspectorObjectImpl(V8Debugger* debugger,
maxAsyncDepth); maxAsyncDepth);
} }
std::unique_ptr<protocol::Runtime::API::StackTrace>
V8StackTraceImpl::buildInspectorObject() const {
return buildInspectorObjectImpl(nullptr);
}
std::unique_ptr<protocol::Runtime::API::StackTrace> std::unique_ptr<protocol::Runtime::API::StackTrace>
V8StackTraceImpl::buildInspectorObject(int maxAsyncDepth) const { V8StackTraceImpl::buildInspectorObject(int maxAsyncDepth) const {
return buildInspectorObjectImpl(nullptr, return buildInspectorObjectImpl(nullptr,
......
...@@ -79,8 +79,6 @@ class V8StackTraceImpl : public V8StackTrace { ...@@ -79,8 +79,6 @@ class V8StackTraceImpl : public V8StackTrace {
int topColumnNumber() const override; // 1-based. int topColumnNumber() const override; // 1-based.
int topScriptId() const override; int topScriptId() const override;
StringView topFunctionName() const override; StringView topFunctionName() const override;
std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject()
const override;
std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject( std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject(
int maxAsyncDepth) const override; int maxAsyncDepth) const override;
std::unique_ptr<StringBuffer> toString() const override; std::unique_ptr<StringBuffer> toString() const override;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment