Commit d8a965a0 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

[tools] tools/node/fetch_deps.py returns False.

This will act as a switch so that we can enable Node.js GN builds
via V8 change.

R=machenbach@chromium.org

Bug: v8:6105
Change-Id: Ie786a4dad7f53e4bbf7d8830bb72b1f8031cee12
Reviewed-on: https://chromium-review.googlesource.com/866839Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50612}
parent 6b909391
...@@ -89,5 +89,11 @@ def FetchDeps(v8_path): ...@@ -89,5 +89,11 @@ def FetchDeps(v8_path):
if os.path.isfile(gclient_entries): if os.path.isfile(gclient_entries):
os.remove(gclient_entries) os.remove(gclient_entries)
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
if __name__ == "__main__": if __name__ == "__main__":
FetchDeps(sys.argv[1]) FetchDeps(sys.argv[1])
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment