Commit d88656af authored by michael_dawson's avatar michael_dawson Committed by Commit bot

cctest/test-deoptimization/DeoptimizeCompare was failing on PPC because the...

cctest/test-deoptimization/DeoptimizeCompare was failing on PPC because the path that is optimized for isel incorrectly used integer values instead of Smi's

BUG=

Review URL: https://codereview.chromium.org/996223002

Cr-Commit-Position: refs/heads/master@{#27136}
parent 611eb258
...@@ -3563,8 +3563,8 @@ void StringHelper::GenerateCompareFlatOneByteStrings( ...@@ -3563,8 +3563,8 @@ void StringHelper::GenerateCompareFlatOneByteStrings(
// Conditionally update the result based either on length_delta or // Conditionally update the result based either on length_delta or
// the last comparion performed in the loop above. // the last comparion performed in the loop above.
if (CpuFeatures::IsSupported(ISELECT)) { if (CpuFeatures::IsSupported(ISELECT)) {
__ li(r4, Operand(GREATER)); __ LoadSmiLiteral(r4, Smi::FromInt(GREATER));
__ li(r5, Operand(LESS)); __ LoadSmiLiteral(r5, Smi::FromInt(LESS));
__ isel(eq, r3, r0, r4); __ isel(eq, r3, r0, r4);
__ isel(lt, r3, r5, r3); __ isel(lt, r3, r5, r3);
__ Ret(); __ Ret();
......
...@@ -407,7 +407,6 @@ ...@@ -407,7 +407,6 @@
# issues to be investigated based on latest uplevel # issues to be investigated based on latest uplevel
'test-run-machops/RunWord64EqualInBranchP': [SKIP], 'test-run-machops/RunWord64EqualInBranchP': [SKIP],
'test-deoptimization/DeoptimizeCompare': [SKIP],
# will not pass until we agree/implement changes to serializce.cc # will not pass until we agree/implement changes to serializce.cc
'test-serialize/SerializeInternalReference': [SKIP], 'test-serialize/SerializeInternalReference': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment