Commit d7f8e611 authored by yangguo's avatar yangguo Committed by Commit bot

Increase code space allowance for first page size.

This has become necessary as we have more experimental natives
that run after deserializing from the snapshot.

R=hpayer@chromium.org
BUG=v8:4200
LOG=N

Review URL: https://codereview.chromium.org/1218973002

Cr-Commit-Position: refs/heads/master@{#29367}
parent 57267fef
......@@ -137,7 +137,7 @@ void CalculateFirstPageSizes(bool is_default_snapshot,
2 * context_reservations[context_index].chunk_size()) +
Page::kObjectStartOffset;
// Add a small allowance to the code space for small scripts.
if (space == CODE_SPACE) required += 32 * KB;
if (space == CODE_SPACE) required += 64 * KB;
} else {
// We expect the vanilla snapshot to only require on page per space.
DCHECK(!is_default_snapshot);
......
......@@ -154,9 +154,6 @@
# BUG(v8:3434).
' test-api/LoadICFastApi_DirectCall_GCMoveStubWithProfiler': [SKIP],
# BUG(v8:4200).
'test-spaces/SizeOfFirstPageIsLargeEnough': [PASS, FAIL],
}], # 'arch == arm64'
['arch == arm64 and simulator_run == True', {
......@@ -293,9 +290,6 @@
'test-serialize/DeserializeFromSecondSerializationAndRunScript2': [SKIP],
'test-serialize/DeserializeAndRunScript2': [SKIP],
'test-serialize/DeserializeFromSecondSerialization': [SKIP],
# BUG(v8:4200).
'test-spaces/SizeOfFirstPageIsLargeEnough': [PASS, FAIL],
}], # 'arch == mips64el'
##############################################################################
......
......@@ -439,6 +439,9 @@ TEST(SizeOfFirstPageIsLargeEnough) {
if (!isolate->snapshot_available()) return;
if (Snapshot::EmbedsScript(isolate)) return;
// If this test fails due to enabling experimental natives that are not part
// of the snapshot, we may need to adjust CalculateFirstPageSizes.
// Freshly initialized VM gets by with one page per space.
for (int i = FIRST_PAGED_SPACE; i <= LAST_PAGED_SPACE; i++) {
// Debug code can be very large, so skip CODE_SPACE if we are generating it.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment