Return undefined if fractionalSecondDigits is 0

Bug: v8:10686
Change-Id: I5a7b47dd4ed10142a795de56c4739ab072e63421
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286814
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Frank Tang <ftang@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68773}

src/objects/js-date-time-format.cc

@@ -650,10 +650,12 @@ MaybeHandle<JSObject> JSDateTimeFormat::ResolvedOptions(
     }
     if (FLAG_harmony_intl_dateformat_fractional_second_digits) {
       int fsd = FractionalSecondDigitsFromPattern(pattern);
-      CHECK(JSReceiver::CreateDataProperty(
-                isolate, options, factory->fractionalSecondDigits_string(),
-                factory->NewNumberFromInt(fsd), Just(kDontThrow))
-                .FromJust());
+      if (fsd > 0) {
+        CHECK(JSReceiver::CreateDataProperty(
+                  isolate, options, factory->fractionalSecondDigits_string(),
+                  factory->NewNumberFromInt(fsd), Just(kDontThrow))
+                  .FromJust());
+      }
     }
   }
 

test/intl/date-format/property-override.js

@@ -71,7 +71,6 @@ var expectedProperties = [
   'minute',
   'second',
   'timeZoneName',
-  'fractionalSecondDigits',
 ];
 
 assertEquals(expectedProperties.length, properties.length);

test/intl/regress-10438.js

@@ -5,7 +5,7 @@
 // Flags: --harmony_intl_dateformat_fractional_second_digits
 
 assertEquals(
-    0,
+    undefined,
     (new Intl.DateTimeFormat("en", {fractionalSecondDigits: 0}))
         .resolvedOptions().fractionalSecondDigits);
 
@@ -25,14 +25,14 @@ assertEquals(
         .resolvedOptions().fractionalSecondDigits);
 
 // When timeStyle and dateStyle is not present, GetNumberOption will fallback
-// to 0 as default regardless fractionalSecondDigits is present in the option or
+// to undefined as default regardless fractionalSecondDigits is present in the option or
 // not.
 assertEquals(
-    0,
+    undefined,
     (new Intl.DateTimeFormat()).resolvedOptions().fractionalSecondDigits);
 
 assertEquals(
-    0,
+    undefined,
     (new Intl.DateTimeFormat("en", {fractionalSecondDigits: undefined}))
         .resolvedOptions().fractionalSecondDigits);
 

test/test262/test262.status

@@ -665,9 +665,6 @@
   # https://crbug.com/v8/10688
   'language/expressions/optional-chaining/eval-optional-call': [FAIL],
 
-  # https://crbug.com/v8/10686
-  'intl402/DateTimeFormat/constructor-options-fractionalSecondDigits-valid': [FAIL],
-
   ######################## NEEDS INVESTIGATION ###########################
 
   # https://bugs.chromium.org/p/v8/issues/detail?id=7833