[compiler] Don't spawn extra tasks when node_observer is set

The mechanisms don't interact well. NodeObserver assumes synchronous
compilation that finishes within the ObserverNodeScope. One could
ensure all relevant lifetimes (of the NodeObserver itself, and all
captured pointers) exceed that of all spawned jobs, but simply
disabling the additional concurrent job in these cases is a
pragmatic fix for now.

Bug: v8:11658
Change-Id: I41b2f96f0166b661cf0cca94ef809ca99475e420
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2833915
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74022}

src/codegen/compiler.cc

@@ -1969,7 +1969,8 @@ bool Compiler::Compile(Isolate* isolate, Handle<JSFunction> function,
     const ConcurrencyMode concurrency_mode = ConcurrencyMode::kNotConcurrent;
 
     if (FLAG_stress_concurrent_inlining && FLAG_concurrent_recompilation &&
-        concurrency_mode == ConcurrencyMode::kNotConcurrent) {
+        concurrency_mode == ConcurrencyMode::kNotConcurrent &&
+        isolate->node_observer() == nullptr) {
       SpawnDuplicateConcurrentJobForStressTesting(function, concurrency_mode,
                                                   code_kind);
     }
@@ -2073,7 +2074,8 @@ bool Compiler::CompileOptimized(Isolate* isolate, Handle<JSFunction> function,
   DCHECK(AllowCompilation::IsAllowed(isolate));
 
   if (FLAG_stress_concurrent_inlining && FLAG_concurrent_recompilation &&
-      mode == ConcurrencyMode::kNotConcurrent) {
+      mode == ConcurrencyMode::kNotConcurrent &&
+      isolate->node_observer() == nullptr) {
     SpawnDuplicateConcurrentJobForStressTesting(function, mode, code_kind);
   }
 

test/cctest/cctest.status

@@ -712,8 +712,6 @@
   'test-heap/LeakNativeContextVia*': [PASS, FAIL],
   'test-heap/NewSpaceObjectsInOptimizedCode': [PASS, FAIL],
   'test-heap/ObjectsInEagerlyDeoptimizedCodeAreWeak': [PASS, FAIL],
-  # crbug.com/v8/11650: Flakily failing after increased coverage.
-  'test-js-to-wasm/*': [PASS, FAIL],
 }], # variant == stress_concurrent_inlining
 
 ]