Commit cd04f804 authored by Michael Lippautz's avatar Michael Lippautz Committed by V8 LUCI CQ

[handles] Fix benign data race

Upon destroying a v8::TracedReference while concurrent marking is
running, we merely reset the object pointer but do not get rid of the
global handle.

We were also restting the parameter which would read the internal
state for a DCHECK. Remove this clearing as the parameter field is not
used for v8::TracedReference.

Bug: chromium:1324074
Change-Id: Ic21bad78deba0925e12c3fc1215b087d0ef5dd7a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3637796Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80459}
parent 02261c4b
...@@ -1125,7 +1125,6 @@ void GlobalHandles::DestroyTracedReference(Address* location) { ...@@ -1125,7 +1125,6 @@ void GlobalHandles::DestroyTracedReference(Address* location) {
// still be spuriously marked as live and is then only reclaimed on the // still be spuriously marked as live and is then only reclaimed on the
// next cycle. // next cycle.
node->clear_object(); node->clear_object();
node->set_parameter(nullptr);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment