Commit c9da6609 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

Revert "[asm.js] Switch test coverage to --fast-validate-asm."

This reverts commit 15898daf.

Reason for revert: Bunch of custom snapshot check failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/11887
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/13603

Original change's description:
> [asm.js] Switch test coverage to --fast-validate-asm.
> 
> R=​machenbach@chromium.org
> BUG=v8:6127
> 
> Change-Id: I65a6905e57ff47195503b37118c279d22f0baba0
> Reviewed-on: https://chromium-review.googlesource.com/459536
> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#44099}

TBR=bradnelson@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,v8-reviews@googlegroups.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6127

Change-Id: Iecbd29d8ee31b49e553048c6f59670167cd22d9d
Reviewed-on: https://chromium-review.googlesource.com/459497Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44103}
parent c769745d
...@@ -664,42 +664,14 @@ ...@@ -664,42 +664,14 @@
# need to re-enable these for the "new" validator. # need to re-enable these for the "new" validator.
'code-coverage-precise': [SKIP], 'code-coverage-precise': [SKIP],
'object-freeze': [SKIP], 'object-freeze': [SKIP],
'asm/asm-validation': [SKIP],
'asm/infinite-loops': [SKIP],
'es6/completion': [SKIP], 'es6/completion': [SKIP],
'es6/function-length-configurable': [SKIP], 'es6/function-length-configurable': [SKIP],
'es6/object-assign': [SKIP], 'es6/object-assign': [SKIP],
'es6/proxies-cross-realm-exception': [SKIP], 'es6/proxies-cross-realm-exception': [SKIP],
'harmony/function-tostring': [SKIP], 'harmony/function-tostring': [SKIP],
'compiler/regress-445859': [SKIP],
'compiler/regress-452427': [SKIP],
'regress/regress-353058': [SKIP],
'regress/regress-458987': [SKIP],
'regress/regress-599068-func-bindings': [SKIP], 'regress/regress-599068-func-bindings': [SKIP],
'regress/regress-599719': [SKIP],
'regress/regress-618608': [SKIP],
'regress/regress-619382': [SKIP], 'regress/regress-619382': [SKIP],
'regress/regress-632289': [SKIP], 'regress/regress-632289': [SKIP],
'regress/regress-670808': [SKIP],
'regress/regress-crbug-530598': [SKIP],
'wasm/asm-wasm': [SKIP],
'wasm/asm-wasm-exception-in-tonumber': [SKIP],
'wasm/asm-wasm-stack': [SKIP],
'wasm/errors': [SKIP],
# Issue 6127: Tiggers ASAN reports with "new" validator.
'asm/b5528-comma': [SKIP],
'asm/if-folding': [SKIP],
'asm/if-reduction': [SKIP],
'wasm/embenchen/box2d': [SKIP],
'wasm/embenchen/copy': [SKIP],
'wasm/embenchen/corrections': [SKIP],
'wasm/embenchen/fannkuch': [SKIP],
'wasm/embenchen/fasta': [SKIP],
'wasm/embenchen/lua_binarytrees': [SKIP],
'wasm/embenchen/memops': [SKIP],
'wasm/embenchen/primes': [SKIP],
'wasm/embenchen/zlib': [SKIP],
}], # variant == asm_wasm }], # variant == asm_wasm
['variant == wasm_traps', { ['variant == wasm_traps', {
......
...@@ -12,7 +12,7 @@ ALL_VARIANT_FLAGS = { ...@@ -12,7 +12,7 @@ ALL_VARIANT_FLAGS = {
"noturbofan_stress": [["--no-turbo", "--stress-opt", "--always-opt"]], "noturbofan_stress": [["--no-turbo", "--stress-opt", "--always-opt"]],
"fullcode": [["--nocrankshaft", "--no-turbo"]], "fullcode": [["--nocrankshaft", "--no-turbo"]],
"nooptimization": [["--nocrankshaft", "--turbo-filter=~"]], "nooptimization": [["--nocrankshaft", "--turbo-filter=~"]],
"asm_wasm": [["--validate-asm", "--fast-validate-asm", "--stress-validate-asm"]], "asm_wasm": [["--validate-asm", "--stress-validate-asm"]],
"wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]], "wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]],
} }
...@@ -25,7 +25,7 @@ FAST_VARIANT_FLAGS = { ...@@ -25,7 +25,7 @@ FAST_VARIANT_FLAGS = {
"noturbofan_stress": [["--no-turbo", "--stress-opt"]], "noturbofan_stress": [["--no-turbo", "--stress-opt"]],
"fullcode": [["--nocrankshaft", "--no-turbo"]], "fullcode": [["--nocrankshaft", "--no-turbo"]],
"nooptimization": [["--nocrankshaft", "--turbo-filter=~"]], "nooptimization": [["--nocrankshaft", "--turbo-filter=~"]],
"asm_wasm": [["--validate-asm", "--fast-validate-asm", "--stress-validate-asm"]], "asm_wasm": [["--validate-asm", "--stress-validate-asm"]],
"wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]], "wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]],
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment