Commit c887113d authored by rmcilroy's avatar rmcilroy Committed by Commit bot

[Tests] Fix some concurrent optimization tests on Ignition.

BUG=v8:4680

Review-Url: https://codereview.chromium.org/2467223004
Cr-Commit-Position: refs/heads/master@{#40718}
parent 7d94be51
......@@ -53,9 +53,15 @@ f(g(1));
assertUnoptimized(f);
assertUnoptimized(g);
%BaselineFunctionOnNextCall(f);
%BaselineFunctionOnNextCall(g);
f(g(2));
assertUnoptimized(f);
assertUnoptimized(g);
%OptimizeFunctionOnNextCall(f, "concurrent");
%OptimizeFunctionOnNextCall(g, "concurrent");
f(g(2)); // Kick off recompilation.
f(g(3)); // Kick off recompilation.
assertUnoptimized(f, "no sync"); // Not yet optimized since recompilation
assertUnoptimized(g, "no sync"); // is still blocked.
......
......@@ -640,18 +640,9 @@
}], # variant == turbofan_opt
##############################################################################
['variant == ignition', {
['variant == ignition or variant == ignition_staging', {
# TODO(5587): fails to liveedit evaled code.
'debug-liveedit-double-call': [FAIL],
# Might trigger stack overflow.
'unicode-test': [SKIP],
# Fails because concurrent compilation is not triggered on bytecode.
# Check in Runtime_OptimizeFunctionOnNextCall.
'compiler/manual-concurrent-recompile': [FAIL],
'regress/regress-embedded-cons-string': [FAIL],
'regress/regress-prepare-break-while-recompile': [FAIL],
}], # variant == ignition
['variant == ignition and msan', {
......@@ -667,19 +658,9 @@
'es6/tail-call-megatest*': [SKIP],
}], # variant == ignition and msan
##############################################################################
['variant == ignition_staging', {
'debug-liveedit-double-call': [FAIL],
# Fails because concurrent compilation is not triggered on bytecode.
# Check in Runtime_OptimizeFunctionOnNextCall.
'compiler/manual-concurrent-recompile': [FAIL],
'regress/regress-embedded-cons-string': [FAIL],
'regress/regress-prepare-break-while-recompile': [FAIL],
}], # variant == ignition_staging
##############################################################################
['variant == ignition_turbofan', {
# TODO(5587): fails to liveedit evaled code.
'debug-liveedit-double-call': [FAIL],
# TODO(rmcilroy,titzer): Times out after
......@@ -691,7 +672,6 @@
# TODO(rmcilroy): Flaky OOM.
'unicodelctest-no-optimization': [SKIP],
}], # variant == ignition_turbofan
['variant == ignition_turbofan and arch == arm', {
......
......@@ -36,6 +36,7 @@ if (!%IsConcurrentRecompilationSupported()) {
function test(fun) {
fun();
%BaselineFunctionOnNextCall(fun);
fun();
// Mark for concurrent optimization.
%OptimizeFunctionOnNextCall(fun, "concurrent");
......
......@@ -45,6 +45,8 @@ function bar() {
return x;
}
foo();
%BaselineFunctionOnNextCall(foo);
foo();
// Mark and kick off recompilation.
%OptimizeFunctionOnNextCall(foo, "concurrent");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment