Commit c5797f85 authored by machenbach's avatar machenbach Committed by Commit bot

Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of...

Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of https://codereview.chromium.org/1103173002/)

Reason for revert:
[Sheriff] Fails compilation on chromium android:
http://build.chromium.org/p/client.v8/builders/Android%20Builder/builds/4131

Is the chromium version our builder used maybe too old (it uses lkcr)? In that case please reland as soon as it's up-to-date.

Original issue's description:
> deprecate non-phantom weak callbacks
>
> BUG=
>
> Committed: https://crrev.com/39c31da2142ab0fca9dae279b9e59cd4951a1982
> Cr-Commit-Position: refs/heads/master@{#28077}

TBR=jochen@chromium.org,dcarney@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1104163002

Cr-Commit-Position: refs/heads/master@{#28079}
parent db1674c5
...@@ -542,13 +542,13 @@ template <class T> class PersistentBase { ...@@ -542,13 +542,13 @@ template <class T> class PersistentBase {
* critical form of resource management! * critical form of resource management!
*/ */
template <typename P> template <typename P>
V8_INLINE V8_DEPRECATED( V8_INLINE V8_DEPRECATE_SOON(
"use WeakCallbackInfo version", "use WeakCallbackInfo version",
void SetWeak(P* parameter, void SetWeak(P* parameter,
typename WeakCallbackData<T, P>::Callback callback)); typename WeakCallbackData<T, P>::Callback callback));
template <typename S, typename P> template <typename S, typename P>
V8_INLINE V8_DEPRECATED( V8_INLINE V8_DEPRECATE_SOON(
"use WeakCallbackInfo version", "use WeakCallbackInfo version",
void SetWeak(P* parameter, void SetWeak(P* parameter,
typename WeakCallbackData<S, P>::Callback callback)); typename WeakCallbackData<S, P>::Callback callback));
...@@ -560,7 +560,7 @@ template <class T> class PersistentBase { ...@@ -560,7 +560,7 @@ template <class T> class PersistentBase {
// specify a parameter for the callback or the location of two internal // specify a parameter for the callback or the location of two internal
// fields in the dying object. // fields in the dying object.
template <typename P> template <typename P>
V8_INLINE V8_DEPRECATED( V8_INLINE V8_DEPRECATE_SOON(
"use SetWeak", "use SetWeak",
void SetPhantom(P* parameter, void SetPhantom(P* parameter,
typename WeakCallbackInfo<P>::Callback callback, typename WeakCallbackInfo<P>::Callback callback,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment