Commit bbd222f8 authored by hpayer's avatar hpayer Committed by Commit bot

Revert of Experiment: reduce heap growing factor to investigate OOM impact....

Revert of Experiment: reduce heap growing factor to investigate OOM impact. (patchset #4 id:60001 of https://codereview.chromium.org/1060533003/)

Reason for revert:
Experiment done.

Original issue's description:
> Experiment: reduce heap growing factor to investigate OOM impact.
>
> This CL will be reverted after getting sufficient data.
> BUG=
>
> Committed: https://crrev.com/8b737395c8fcde35cbfbed6607f767ed48eefc5b
> Cr-Commit-Position: refs/heads/master@{#27804}

TBR=ulan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1085353003

Cr-Commit-Position: refs/heads/master@{#27871}
parent addb1063
......@@ -5183,11 +5183,11 @@ intptr_t Heap::OldGenerationAllocationLimit(intptr_t old_gen_size,
const int kMaxHandles = 1000;
const int kMinHandles = 100;
double min_factor = 1.1;
double max_factor = 1.5;
double max_factor = 4;
// We set the old generation growing factor to 2 to grow the heap slower on
// memory-constrained devices.
if (max_old_generation_size_ <= kMaxOldSpaceSizeMediumMemoryDevice) {
max_factor = 1.5;
max_factor = 2;
}
// If there are many freed global handles, then the next full GC will
// likely collect a lot of garbage. Choose the heap growing factor
......
......@@ -6646,8 +6646,7 @@ void InternalFieldCallback(bool global_gc) {
}
}
if (global_gc) {
CcTest::heap()->CollectAllGarbage(
TestHeap::Heap::kAbortIncrementalMarkingMask);
CcTest::heap()->CollectAllGarbage(TestHeap::Heap::kNoGCFlags);
} else {
CcTest::heap()->CollectGarbage(i::NEW_SPACE);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment