Commit baa2840f authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[wasm] Add variant for --wasm-write-protect-code-memory

This adds a test variant enabling --wasm-write-protect-code-memory, and
enables it on linux64 debug and release bots.

R=machenbach@chromium.org, jkummerow@chromium.org
CC=​dlehmann@google.com

Bug: v8:11667, v8:11663
Change-Id: I04f47d06d9720f7bc9e122d17b253646f2c203b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2839562
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74179}
parent 12aa090e
...@@ -389,6 +389,8 @@ ...@@ -389,6 +389,8 @@
{'name': 'mjsunit', 'variant': 'experimental_regexp'}, {'name': 'mjsunit', 'variant': 'experimental_regexp'},
# Concurrent inlining. # Concurrent inlining.
{'name': 'mjsunit', 'variant': 'concurrent_inlining'}, {'name': 'mjsunit', 'variant': 'concurrent_inlining'},
# Wasm write protect code space.
{'name': 'mjsunit', 'variant': 'wasm_write_protect_code'},
], ],
}, },
'v8_linux64_gc_stress_custom_snapshot_dbg_ng_triggered': { 'v8_linux64_gc_stress_custom_snapshot_dbg_ng_triggered': {
...@@ -1204,6 +1206,8 @@ ...@@ -1204,6 +1206,8 @@
{'name': 'mjsunit', 'variant': 'experimental_regexp'}, {'name': 'mjsunit', 'variant': 'experimental_regexp'},
# Concurrent inlining. # Concurrent inlining.
{'name': 'mjsunit', 'variant': 'concurrent_inlining'}, {'name': 'mjsunit', 'variant': 'concurrent_inlining'},
# Wasm write protect code space.
{'name': 'mjsunit', 'variant': 'wasm_write_protect_code'},
], ],
}, },
'V8 Linux64 - debug - perfetto': { 'V8 Linux64 - debug - perfetto': {
...@@ -1235,6 +1239,8 @@ ...@@ -1235,6 +1239,8 @@
{'name': 'mjsunit', 'variant': 'experimental_regexp'}, {'name': 'mjsunit', 'variant': 'experimental_regexp'},
# Concurrent inlining. # Concurrent inlining.
{'name': 'mjsunit', 'variant': 'concurrent_inlining'}, {'name': 'mjsunit', 'variant': 'concurrent_inlining'},
# Wasm write protect code space.
{'name': 'mjsunit', 'variant': 'wasm_write_protect_code'},
], ],
}, },
'V8 Linux64 - gcov coverage': { 'V8 Linux64 - gcov coverage': {
......
...@@ -44,6 +44,7 @@ ALL_VARIANT_FLAGS = { ...@@ -44,6 +44,7 @@ ALL_VARIANT_FLAGS = {
"instruction_scheduling": [["--turbo-instruction-scheduling"]], "instruction_scheduling": [["--turbo-instruction-scheduling"]],
"stress_instruction_scheduling": [["--turbo-stress-instruction-scheduling"]], "stress_instruction_scheduling": [["--turbo-stress-instruction-scheduling"]],
"top_level_await": [["--harmony-top-level-await"]], "top_level_await": [["--harmony-top-level-await"]],
"wasm_write_protect_code": [["--wasm-write-protect-code-memory"]],
} }
# Flags that lead to a contradiction with the flags provided by the respective # Flags that lead to a contradiction with the flags provided by the respective
...@@ -76,6 +77,9 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = { ...@@ -76,6 +77,9 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = {
"no_local_heaps": ["--concurrent-inlining", "--turboprop"], "no_local_heaps": ["--concurrent-inlining", "--turboprop"],
"experimental_regexp": ["--no-enable-experimental-regexp-engine", "experimental_regexp": ["--no-enable-experimental-regexp-engine",
"--no-default-to-experimental-regexp-engine"], "--no-default-to-experimental-regexp-engine"],
# There is a negative implication: --perf-prof disables
# --wasm-write-protect-code-memory.
"wasm_write_protect_code": ["--perf-prof"],
} }
# Flags that lead to a contradiction under certain build variables. # Flags that lead to a contradiction under certain build variables.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment