Commit aec28626 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[build] Dump build configuration for all v8 executables

Before this CL, cctest with component build will depend on the static v8
snapshot target and omit to dump the build configuration.

Now we simply write the configuration when building any v8
executable. In pure library builds, we don't need the configuration, as
it's used by the test framework to auto-detect testing options.

Bug: v8:5918
Change-Id: Ie85ba82a2803542f0a0c88d6044167138fdd7d4f
Reviewed-on: https://chromium-review.googlesource.com/554690Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46305}
parent 1163aba7
...@@ -2708,10 +2708,6 @@ if (is_component_build) { ...@@ -2708,10 +2708,6 @@ if (is_component_build) {
"src/v8dll-main.cc", "src/v8dll-main.cc",
] ]
deps = [
":v8_dump_build_config",
]
public_deps = [ public_deps = [
":v8_base", ":v8_base",
":v8_maybe_snapshot", ":v8_maybe_snapshot",
...@@ -2729,10 +2725,6 @@ if (is_component_build) { ...@@ -2729,10 +2725,6 @@ if (is_component_build) {
"src/v8dll-main.cc", "src/v8dll-main.cc",
] ]
deps = [
":v8_dump_build_config",
]
public_deps = [ public_deps = [
":v8_base", ":v8_base",
":v8_maybe_snapshot", ":v8_maybe_snapshot",
...@@ -2748,10 +2740,6 @@ if (is_component_build) { ...@@ -2748,10 +2740,6 @@ if (is_component_build) {
} }
} else { } else {
group("v8") { group("v8") {
deps = [
":v8_dump_build_config",
]
public_deps = [ public_deps = [
":v8_base", ":v8_base",
":v8_maybe_snapshot", ":v8_maybe_snapshot",
...@@ -2763,10 +2751,6 @@ if (is_component_build) { ...@@ -2763,10 +2751,6 @@ if (is_component_build) {
group("v8_for_testing") { group("v8_for_testing") {
testonly = true testonly = true
deps = [
":v8_dump_build_config",
]
public_deps = [ public_deps = [
":v8_base", ":v8_base",
":v8_maybe_snapshot", ":v8_maybe_snapshot",
......
...@@ -156,6 +156,9 @@ template("v8_executable") { ...@@ -156,6 +156,9 @@ template("v8_executable") {
configs -= [ v8_path_prefix + ":v8_gcov_coverage_cflags" ] configs -= [ v8_path_prefix + ":v8_gcov_coverage_cflags" ]
} }
} }
deps += [
v8_path_prefix + ":v8_dump_build_config",
]
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment