Commit aa97b065 authored by vogelheim's avatar vogelheim Committed by Commit bot

Revert of Debugger: clear shared function info list when recompiling for...

Revert of Debugger: clear shared function info list when recompiling for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1270313003/ )

Reason for revert:
Sorry for revert, but this change breaks one of the webkit-unit-tests.

Example here: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Win/1178/layout-test-results/inspector/sources/debugger/live-edit-no-reveal-diff.txt

Not sure if the old expectations were right, or the new ones are. :)

Original issue's description:
> Debugger: clear shared function info list when recompiling for liveedit.
>
> R=bmeurer@chromium.org
> BUG=chromium:517594
> LOG=N
>
> Committed: https://crrev.com/9eea3ef5147a5e15256093fb4c36a7598d60d128
> Cr-Commit-Position: refs/heads/master@{#30111}

TBR=bmeurer@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:517594

Review URL: https://codereview.chromium.org/1279613008

Cr-Commit-Position: refs/heads/master@{#30112}
parent 9eea3ef5
...@@ -1054,7 +1054,6 @@ void Compiler::CompileForLiveEdit(Handle<Script> script) { ...@@ -1054,7 +1054,6 @@ void Compiler::CompileForLiveEdit(Handle<Script> script) {
VMState<COMPILER> state(info.isolate()); VMState<COMPILER> state(info.isolate());
// Get rid of old list of shared function infos. // Get rid of old list of shared function infos.
script->set_shared_function_infos(Smi::FromInt(0));
info.MarkAsFirstCompile(); info.MarkAsFirstCompile();
info.parse_info()->set_global(); info.parse_info()->set_global();
if (!Parser::ParseStatic(info.parse_info())) return; if (!Parser::ParseStatic(info.parse_info())) return;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment