Commit a7cdc10f authored by rodolph.perfetta's avatar rodolph.perfetta Committed by Commit bot

[arm64] serialize internal references via object visitor

BUG=

Review URL: https://codereview.chromium.org/1020863003

Cr-Commit-Position: refs/heads/master@{#27311}
parent b7dc9c58
...@@ -661,7 +661,7 @@ void Assembler::deserialization_set_special_target_at( ...@@ -661,7 +661,7 @@ void Assembler::deserialization_set_special_target_at(
void Assembler::deserialization_set_target_internal_reference_at( void Assembler::deserialization_set_target_internal_reference_at(
Address pc, Address target) { Address pc, Address target) {
UNIMPLEMENTED(); // ARM64 does not use internal references. Memory::Address_at(pc) = target;
} }
...@@ -752,15 +752,13 @@ Address RelocInfo::target_external_reference() { ...@@ -752,15 +752,13 @@ Address RelocInfo::target_external_reference() {
Address RelocInfo::target_internal_reference() { Address RelocInfo::target_internal_reference() {
DCHECK(rmode_ == INTERNAL_REFERENCE); DCHECK(rmode_ == INTERNAL_REFERENCE);
UNIMPLEMENTED(); // ARM64 does not use internal references. return Memory::Address_at(pc_);
return NULL;
} }
Address RelocInfo::target_internal_reference_address() { Address RelocInfo::target_internal_reference_address() {
DCHECK(rmode_ == INTERNAL_REFERENCE); DCHECK(rmode_ == INTERNAL_REFERENCE);
UNIMPLEMENTED(); // ARM64 does not use internal references. return reinterpret_cast<Address>(pc_);
return NULL;
} }
...@@ -855,7 +853,7 @@ void RelocInfo::WipeOut() { ...@@ -855,7 +853,7 @@ void RelocInfo::WipeOut() {
IsRuntimeEntry(rmode_) || IsExternalReference(rmode_) || IsRuntimeEntry(rmode_) || IsExternalReference(rmode_) ||
IsInternalReference(rmode_)); IsInternalReference(rmode_));
if (IsInternalReference(rmode_)) { if (IsInternalReference(rmode_)) {
UNIMPLEMENTED(); // ARM64 does not use internal references. Memory::Address_at(pc_) = NULL;
} else { } else {
Assembler::set_target_address_at(pc_, host_, NULL); Assembler::set_target_address_at(pc_, host_, NULL);
} }
...@@ -891,7 +889,7 @@ void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) { ...@@ -891,7 +889,7 @@ void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {
} else if (mode == RelocInfo::EXTERNAL_REFERENCE) { } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
visitor->VisitExternalReference(this); visitor->VisitExternalReference(this);
} else if (mode == RelocInfo::INTERNAL_REFERENCE) { } else if (mode == RelocInfo::INTERNAL_REFERENCE) {
UNIMPLEMENTED(); // ARM64 does not use internal references. visitor->VisitInternalReference(this);
} else if (((RelocInfo::IsJSReturn(mode) && } else if (((RelocInfo::IsJSReturn(mode) &&
IsPatchedReturnSequence()) || IsPatchedReturnSequence()) ||
(RelocInfo::IsDebugBreakSlot(mode) && (RelocInfo::IsDebugBreakSlot(mode) &&
...@@ -916,7 +914,7 @@ void RelocInfo::Visit(Heap* heap) { ...@@ -916,7 +914,7 @@ void RelocInfo::Visit(Heap* heap) {
} else if (mode == RelocInfo::EXTERNAL_REFERENCE) { } else if (mode == RelocInfo::EXTERNAL_REFERENCE) {
StaticVisitor::VisitExternalReference(this); StaticVisitor::VisitExternalReference(this);
} else if (mode == RelocInfo::INTERNAL_REFERENCE) { } else if (mode == RelocInfo::INTERNAL_REFERENCE) {
UNIMPLEMENTED(); // ARM64 does not use internal references. StaticVisitor::VisitInternalReference(this);
} else if (heap->isolate()->debug()->has_break_points() && } else if (heap->isolate()->debug()->has_break_points() &&
((RelocInfo::IsJSReturn(mode) && ((RelocInfo::IsJSReturn(mode) &&
IsPatchedReturnSequence()) || IsPatchedReturnSequence()) ||
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment