Commit a2d293b8 authored by Michael Achenbach's avatar Michael Achenbach Committed by V8 LUCI CQ

[build] Disable gcc warnings for unittests

This is a workaround to silence gcc failures stemming from googletest
headers.

Bug: chromium:1307180
Change-Id: Ia6eb08f170f65c2fde6e4c287f9781d9df559b35
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3738220Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81548}
parent 544fca5f
...@@ -22,6 +22,15 @@ if (is_fuchsia) { ...@@ -22,6 +22,15 @@ if (is_fuchsia) {
} }
} }
config("gcc_warnings_not_errors") {
if (!is_clang && !is_win) {
cflags = [
# Turn off warning as errors due to false positives in googletest.
"-Wno-error",
]
}
}
v8_executable("v8_heap_base_unittests") { v8_executable("v8_heap_base_unittests") {
testonly = true testonly = true
...@@ -50,6 +59,7 @@ v8_source_set("v8_heap_base_unittests_sources") { ...@@ -50,6 +59,7 @@ v8_source_set("v8_heap_base_unittests_sources") {
configs = [ configs = [
"../..:external_config", "../..:external_config",
"../..:internal_config_base", "../..:internal_config_base",
":gcc_warnings_not_errors",
] ]
deps = [ deps = [
...@@ -150,6 +160,7 @@ v8_source_set("cppgc_unittests_sources") { ...@@ -150,6 +160,7 @@ v8_source_set("cppgc_unittests_sources") {
"../..:external_config", "../..:external_config",
"../..:internal_config_base", "../..:internal_config_base",
"../..:cppgc_base_config", "../..:cppgc_base_config",
":gcc_warnings_not_errors",
] ]
deps = [ deps = [
...@@ -619,6 +630,7 @@ v8_source_set("unittests_sources") { ...@@ -619,6 +630,7 @@ v8_source_set("unittests_sources") {
"../..:cppgc_base_config", "../..:cppgc_base_config",
"../..:external_config", "../..:external_config",
"../..:internal_config_base", "../..:internal_config_base",
":gcc_warnings_not_errors",
] ]
deps = [ deps = [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment