Commit a0f5d499 authored by hablich's avatar hablich Committed by Commit bot

Revert of GetOwnPropertyDescriptor: API-style accessors can throw, check for...

Revert of GetOwnPropertyDescriptor: API-style accessors can throw, check for that. (patchset #1 id:1 of https://codereview.chromium.org/1412823003/ )

Reason for revert:
Breaks test if rolled into Chromium: http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=60441

Original issue's description:
> GetOwnPropertyDescriptor: API-style accessors can throw, check for that.
>
> Committed: https://crrev.com/cbda86196b0b52694f50982ae3f1ac8e72056e6d
> Cr-Commit-Position: refs/heads/master@{#31522}

TBR=cbruni@chromium.org,jkummerow@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1421483004

Cr-Commit-Position: refs/heads/master@{#31532}
parent 5308a999
...@@ -6617,11 +6617,7 @@ bool JSReceiver::GetOwnPropertyDescriptor(LookupIterator* it, ...@@ -6617,11 +6617,7 @@ bool JSReceiver::GetOwnPropertyDescriptor(LookupIterator* it,
it->GetAccessors()->IsAccessorPair(); it->GetAccessors()->IsAccessorPair();
if (!is_accessor_pair) { if (!is_accessor_pair) {
// 5a. Set D.[[Value]] to the value of X's [[Value]] attribute. // 5a. Set D.[[Value]] to the value of X's [[Value]] attribute.
Handle<Object> value; Handle<Object> value = JSObject::GetProperty(it).ToHandleChecked();
if (!JSObject::GetProperty(it).ToHandle(&value)) {
DCHECK(isolate->has_pending_exception());
return false;
}
desc->set_value(value); desc->set_value(value);
// 5b. Set D.[[Writable]] to the value of X's [[Writable]] attribute // 5b. Set D.[[Writable]] to the value of X's [[Writable]] attribute
desc->set_writable((attrs & READ_ONLY) == 0); desc->set_writable((attrs & READ_ONLY) == 0);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment