Commit a02ef8ff authored by bmeurer@chromium.org's avatar bmeurer@chromium.org

Avoid useless #ifdef DEBUG checks for the --trace-ic flag.

FLAG_trace_ic is constant false in non-DEBUG builds anyways.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/91003002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent f7927265
...@@ -1641,12 +1641,10 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) { ...@@ -1641,12 +1641,10 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) {
return; return;
} }
#ifdef DEBUG
if (FLAG_trace_ic) { if (FLAG_trace_ic) {
PrintF("[ patching ic at %p, cmp=%p, delta=%d\n", PrintF("[ patching ic at %p, cmp=%p, delta=%d\n",
address, cmp_instruction_address, delta); address, cmp_instruction_address, delta);
} }
#endif
Address patch_address = Address patch_address =
cmp_instruction_address - delta * Instruction::kInstrSize; cmp_instruction_address - delta * Instruction::kInstrSize;
......
...@@ -864,7 +864,6 @@ void HydrogenCodeStub::TraceTransition(StateType from, StateType to) { ...@@ -864,7 +864,6 @@ void HydrogenCodeStub::TraceTransition(StateType from, StateType to) {
// Note: Although a no-op transition is semantically OK, it is hinting at a // Note: Although a no-op transition is semantically OK, it is hinting at a
// bug somewhere in our state transition machinery. // bug somewhere in our state transition machinery.
ASSERT(from != to); ASSERT(from != to);
#ifdef DEBUG
if (!FLAG_trace_ic) return; if (!FLAG_trace_ic) return;
char buffer[100]; char buffer[100];
NoAllocationStringAllocator allocator(buffer, NoAllocationStringAllocator allocator(buffer,
...@@ -878,7 +877,6 @@ void HydrogenCodeStub::TraceTransition(StateType from, StateType to) { ...@@ -878,7 +877,6 @@ void HydrogenCodeStub::TraceTransition(StateType from, StateType to) {
to.Print(&stream); to.Print(&stream);
stream.Add("]\n"); stream.Add("]\n");
stream.OutputToStdOut(); stream.OutputToStdOut();
#endif
} }
......
...@@ -879,9 +879,7 @@ MaybeObject* LoadIC::Load(Handle<Object> object, ...@@ -879,9 +879,7 @@ MaybeObject* LoadIC::Load(Handle<Object> object,
} }
if (!stub.is_null()) { if (!stub.is_null()) {
set_target(*stub); set_target(*stub);
#ifdef DEBUG
if (FLAG_trace_ic) PrintF("[LoadIC : +#length /stringwrapper]\n"); if (FLAG_trace_ic) PrintF("[LoadIC : +#length /stringwrapper]\n");
#endif
} }
// Get the string if we have a string wrapper object. // Get the string if we have a string wrapper object.
String* string = String::cast(JSValue::cast(*object)->value()); String* string = String::cast(JSValue::cast(*object)->value());
...@@ -904,9 +902,7 @@ MaybeObject* LoadIC::Load(Handle<Object> object, ...@@ -904,9 +902,7 @@ MaybeObject* LoadIC::Load(Handle<Object> object,
} }
if (!stub.is_null()) { if (!stub.is_null()) {
set_target(*stub); set_target(*stub);
#ifdef DEBUG
if (FLAG_trace_ic) PrintF("[LoadIC : +#prototype /function]\n"); if (FLAG_trace_ic) PrintF("[LoadIC : +#prototype /function]\n");
#endif
} }
return *Accessors::FunctionGetPrototype(Handle<JSFunction>::cast(object)); return *Accessors::FunctionGetPrototype(Handle<JSFunction>::cast(object));
} }
...@@ -2360,7 +2356,6 @@ MaybeObject* BinaryOpIC::Transition(Handle<Object> left, Handle<Object> right) { ...@@ -2360,7 +2356,6 @@ MaybeObject* BinaryOpIC::Transition(Handle<Object> left, Handle<Object> right) {
Maybe<Handle<Object> > result = stub.Result(left, right, isolate()); Maybe<Handle<Object> > result = stub.Result(left, right, isolate());
if (!result.has_value) return Failure::Exception(); if (!result.has_value) return Failure::Exception();
#ifdef DEBUG
if (FLAG_trace_ic) { if (FLAG_trace_ic) {
char buffer[100]; char buffer[100];
NoAllocationStringAllocator allocator(buffer, NoAllocationStringAllocator allocator(buffer,
...@@ -2381,9 +2376,6 @@ MaybeObject* BinaryOpIC::Transition(Handle<Object> left, Handle<Object> right) { ...@@ -2381,9 +2376,6 @@ MaybeObject* BinaryOpIC::Transition(Handle<Object> left, Handle<Object> right) {
} else { } else {
stub.UpdateStatus(left, right, result); stub.UpdateStatus(left, right, result);
} }
#else
stub.UpdateStatus(left, right, result);
#endif
Handle<Code> code = stub.GetCode(isolate()); Handle<Code> code = stub.GetCode(isolate());
set_target(*code); set_target(*code);
...@@ -2612,7 +2604,6 @@ Code* CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) { ...@@ -2612,7 +2604,6 @@ Code* CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) {
Handle<Code> new_target = stub.GetCode(isolate()); Handle<Code> new_target = stub.GetCode(isolate());
set_target(*new_target); set_target(*new_target);
#ifdef DEBUG
if (FLAG_trace_ic) { if (FLAG_trace_ic) {
PrintF("[CompareIC in "); PrintF("[CompareIC in ");
JavaScriptFrame::PrintTop(isolate(), stdout, false, true); JavaScriptFrame::PrintTop(isolate(), stdout, false, true);
...@@ -2626,7 +2617,6 @@ Code* CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) { ...@@ -2626,7 +2617,6 @@ Code* CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) {
Token::Name(op_), Token::Name(op_),
static_cast<void*>(*stub.GetCode(isolate()))); static_cast<void*>(*stub.GetCode(isolate())));
} }
#endif
// Activate inlined smi code. // Activate inlined smi code.
if (previous_state == UNINITIALIZED) { if (previous_state == UNINITIALIZED) {
......
...@@ -1650,12 +1650,10 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) { ...@@ -1650,12 +1650,10 @@ void PatchInlinedSmiCode(Address address, InlinedSmiCheck check) {
return; return;
} }
#ifdef DEBUG
if (FLAG_trace_ic) { if (FLAG_trace_ic) {
PrintF("[ patching ic at %p, andi=%p, delta=%d\n", PrintF("[ patching ic at %p, andi=%p, delta=%d\n",
address, andi_instruction_address, delta); address, andi_instruction_address, delta);
} }
#endif
Address patch_address = Address patch_address =
andi_instruction_address - delta * Instruction::kInstrSize; andi_instruction_address - delta * Instruction::kInstrSize;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment