Commit 9b0b3ab0 authored by jgruber's avatar jgruber Committed by Commit Bot

[build] Tweak default value of v8_enable_embedded_builtins

Embedded builtins are currently unsupported in no-snapshot builds.
This lets BUILD.gn reflect that (both in the default value and an added
assertion).

Bug: v8:6666,v8:7837
Change-Id: I5c56f655733505e481017408f8a1a14d857f0b4a
Reviewed-on: https://chromium-review.googlesource.com/1096758Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53716}
parent 874d5ba1
...@@ -79,7 +79,8 @@ declare_args() { ...@@ -79,7 +79,8 @@ declare_args() {
# TODO(jgruber,v8:6666): Support ia32 and maybe MSVC. # TODO(jgruber,v8:6666): Support ia32 and maybe MSVC.
# TODO(jgruber,v8:6666): Enable for remaining architectures once performance # TODO(jgruber,v8:6666): Enable for remaining architectures once performance
# regressions are addressed. # regressions are addressed.
v8_enable_embedded_builtins = v8_current_cpu == "x64" && (!is_win || is_clang) v8_enable_embedded_builtins =
v8_use_snapshot && v8_current_cpu == "x64" && (!is_win || is_clang)
# Enable code-generation-time checking of types in the CodeStubAssembler. # Enable code-generation-time checking of types in the CodeStubAssembler.
v8_enable_verify_csa = false v8_enable_verify_csa = false
...@@ -187,6 +188,9 @@ if (v8_check_microtasks_scopes_consistency == "") { ...@@ -187,6 +188,9 @@ if (v8_check_microtasks_scopes_consistency == "") {
v8_enable_debugging_features || dcheck_always_on v8_enable_debugging_features || dcheck_always_on
} }
assert(!v8_enable_embedded_builtins || v8_use_snapshot,
"Embedded builtins only work with snapshots")
# Specifies if the target build is a simulator build. Comparing target cpu # Specifies if the target build is a simulator build. Comparing target cpu
# with v8 target cpu to not affect simulator builds for making cross-compile # with v8 target cpu to not affect simulator builds for making cross-compile
# snapshots. # snapshots.
...@@ -360,7 +364,7 @@ config("features") { ...@@ -360,7 +364,7 @@ config("features") {
if (v8_check_microtasks_scopes_consistency) { if (v8_check_microtasks_scopes_consistency) {
defines += [ "V8_CHECK_MICROTASKS_SCOPES_CONSISTENCY" ] defines += [ "V8_CHECK_MICROTASKS_SCOPES_CONSISTENCY" ]
} }
if (v8_enable_embedded_builtins && v8_use_snapshot) { if (v8_enable_embedded_builtins) {
defines += [ "V8_EMBEDDED_BUILTINS" ] defines += [ "V8_EMBEDDED_BUILTINS" ]
} }
if (v8_use_multi_snapshots) { if (v8_use_multi_snapshots) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment