Commit 9afefcbc authored by Simon Zünd's avatar Simon Zünd Committed by Commit Bot

[cleanup] Rename field offsets in StackFrameInfo

This CL renames field offsets from *Index to *Offset in the
StackFrameInfo class for consistency.

R=mstarzinger@chromium.org

Bug: v8:8562
Change-Id: I9ccec3e6f924a4040d26dc677fdd1ec620cf0463
Reviewed-on: https://chromium-review.googlesource.com/c/1460937Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59460}
parent 8dd72125
...@@ -21,18 +21,18 @@ NEVER_READ_ONLY_SPACE_IMPL(StackFrameInfo) ...@@ -21,18 +21,18 @@ NEVER_READ_ONLY_SPACE_IMPL(StackFrameInfo)
CAST_ACCESSOR(StackFrameInfo) CAST_ACCESSOR(StackFrameInfo)
SMI_ACCESSORS(StackFrameInfo, line_number, kLineNumberIndex) SMI_ACCESSORS(StackFrameInfo, line_number, kLineNumberOffset)
SMI_ACCESSORS(StackFrameInfo, column_number, kColumnNumberIndex) SMI_ACCESSORS(StackFrameInfo, column_number, kColumnNumberOffset)
SMI_ACCESSORS(StackFrameInfo, script_id, kScriptIdIndex) SMI_ACCESSORS(StackFrameInfo, script_id, kScriptIdOffset)
ACCESSORS(StackFrameInfo, script_name, Object, kScriptNameIndex) ACCESSORS(StackFrameInfo, script_name, Object, kScriptNameOffset)
ACCESSORS(StackFrameInfo, script_name_or_source_url, Object, ACCESSORS(StackFrameInfo, script_name_or_source_url, Object,
kScriptNameOrSourceUrlIndex) kScriptNameOrSourceUrlOffset)
ACCESSORS(StackFrameInfo, function_name, Object, kFunctionNameIndex) ACCESSORS(StackFrameInfo, function_name, Object, kFunctionNameOffset)
SMI_ACCESSORS(StackFrameInfo, flag, kFlagIndex) SMI_ACCESSORS(StackFrameInfo, flag, kFlagOffset)
BOOL_ACCESSORS(StackFrameInfo, flag, is_eval, kIsEvalBit) BOOL_ACCESSORS(StackFrameInfo, flag, is_eval, kIsEvalBit)
BOOL_ACCESSORS(StackFrameInfo, flag, is_constructor, kIsConstructorBit) BOOL_ACCESSORS(StackFrameInfo, flag, is_constructor, kIsConstructorBit)
BOOL_ACCESSORS(StackFrameInfo, flag, is_wasm, kIsWasmBit) BOOL_ACCESSORS(StackFrameInfo, flag, is_wasm, kIsWasmBit)
SMI_ACCESSORS(StackFrameInfo, id, kIdIndex) SMI_ACCESSORS(StackFrameInfo, id, kIdOffset)
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
......
...@@ -35,16 +35,16 @@ class StackFrameInfo : public Struct { ...@@ -35,16 +35,16 @@ class StackFrameInfo : public Struct {
DECL_VERIFIER(StackFrameInfo) DECL_VERIFIER(StackFrameInfo)
// Layout description. // Layout description.
#define STACK_FRAME_INFO_FIELDS(V) \ #define STACK_FRAME_INFO_FIELDS(V) \
V(kLineNumberIndex, kTaggedSize) \ V(kLineNumberOffset, kTaggedSize) \
V(kColumnNumberIndex, kTaggedSize) \ V(kColumnNumberOffset, kTaggedSize) \
V(kScriptIdIndex, kTaggedSize) \ V(kScriptIdOffset, kTaggedSize) \
V(kScriptNameIndex, kTaggedSize) \ V(kScriptNameOffset, kTaggedSize) \
V(kScriptNameOrSourceUrlIndex, kTaggedSize) \ V(kScriptNameOrSourceUrlOffset, kTaggedSize) \
V(kFunctionNameIndex, kTaggedSize) \ V(kFunctionNameOffset, kTaggedSize) \
V(kFlagIndex, kTaggedSize) \ V(kFlagOffset, kTaggedSize) \
V(kIdIndex, kTaggedSize) \ V(kIdOffset, kTaggedSize) \
/* Total size. */ \ /* Total size. */ \
V(kSize, 0) V(kSize, 0)
DEFINE_FIELD_OFFSET_CONSTANTS(Struct::kHeaderSize, STACK_FRAME_INFO_FIELDS) DEFINE_FIELD_OFFSET_CONSTANTS(Struct::kHeaderSize, STACK_FRAME_INFO_FIELDS)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment