Commit 990c59d8 authored by Ross McIlroy's avatar Ross McIlroy Committed by Commit Bot

Revert "[Counters] Add HistorgramTimers for optimized compile."

This reverts commit 8307ab70.

Reason for revert: Breaks TSAN

Original change's description:
> [Counters] Add HistorgramTimers for optimized compile.
> 
> Will be used for UMA to track time spent optimizing code in the wild.
> 
> Change-Id: Ibc01540552eac4cb9224f1cb6cc11a55aae5834d
> Reviewed-on: https://chromium-review.googlesource.com/444345
> Reviewed-by: Michael Stanton <mvstanton@chromium.org>
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#43374}

TBR=rmcilroy@chromium.org,mvstanton@chromium.org,machenbach@chromium.org,hablich@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I1cfc2ee599b9ba0132e69c8a61b21ff32c74f68e
Reviewed-on: https://chromium-review.googlesource.com/446360Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43396}
parent bdd23acd
......@@ -51,8 +51,6 @@ class OptimizingCompileDispatcher::CompileTask : public v8::Task {
DisallowHandleDereference no_deref;
{
HistogramTimerScope histogram_timer(
isolate_->counters()->compile_optimized_background_thread());
TimerEventScope<TimerEventRecompileConcurrent> timer(isolate_);
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"),
......
......@@ -875,8 +875,6 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function,
return MaybeHandle<Code>();
}
HistogramTimerScope timer(
isolate->counters()->compile_optimized_main_thread());
TimerEventScope<TimerEventOptimizeCode> optimize_code_timer(isolate);
RuntimeCallTimerScope runtimeTimer(isolate, &RuntimeCallStats::OptimizeCode);
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"), "V8.OptimizeCode");
......@@ -931,8 +929,6 @@ CompilationJob::Status FinalizeOptimizedCompilationJob(CompilationJob* job) {
CompilationInfo* info = job->info();
Isolate* isolate = info->isolate();
HistogramTimerScope histogram_timer(
isolate->counters()->compile_optimized_main_thread());
TimerEventScope<TimerEventRecompileSynchronous> timer(info->isolate());
RuntimeCallTimerScope runtimeTimer(isolate,
&RuntimeCallStats::RecompileSynchronous);
......
......@@ -969,11 +969,6 @@ class RuntimeCallTimerScope {
HT(compile_serialize, V8.CompileSerializeMicroSeconds, 100000, MICROSECOND) \
HT(compile_deserialize, V8.CompileDeserializeMicroSeconds, 1000000, \
MICROSECOND) \
/* Optimized compile times. */ \
HT(compile_optimized_main_thread, V8.CompileOptimizedMainThreadMicroSeconds, \
1000000, MICROSECOND) \
HT(compile_optimized_background_thread, \
V8.CompileOptimizeBackgroundThreadMicroSeconds, 1000000, MICROSECOND) \
/* Total compilation time incl. caching/parsing */ \
HT(compile_script, V8.CompileScriptMicroSeconds, 1000000, MICROSECOND) \
/* Total JavaScript execution time (including callbacks and runtime calls */ \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment