Commit 96afb852 authored by hablich's avatar hablich Committed by Commit bot

Revert of [wasm] Identify wasm functions with index into the function tables....

Revert of [wasm] Identify wasm functions with index into the function tables. (patchset #7 id:110001 of https://codereview.chromium.org/2690113012/ )

Reason for revert:
Introduces a new test failure/flake: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/13707

Original issue's description:
> [wasm] Identify wasm functions with index into the function tables.
>
> Currently, the default name for wasm functions in generated code is 'wasm', tag wasm functions with the index into the function table to identify functions. Snippets of sample output with --print-code below.
>
> Before:
> --- Code ---
> kind = WASM_FUNCTION
> name = wasm
> compiler = turbofan
>
> After:
> --- Code ---
> kind = WASM_FUNCTION
> name = wasm#200
> compiler = turbofan
>
> R=mtrofin@chromium.org
>
> Review-Url: https://codereview.chromium.org/2690113012
> Cr-Commit-Position: refs/heads/master@{#43296}
> Committed: https://chromium.googlesource.com/v8/v8/+/5fc3ac29e4d942ccb4c45f6cdcee75d0b394b296

TBR=mtrofin@chromium.org,gdeepti@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2708593002
Cr-Commit-Position: refs/heads/master@{#43302}
parent 56bb134f
...@@ -4011,13 +4011,6 @@ SourcePositionTable* WasmCompilationUnit::BuildGraphForWasmFunction( ...@@ -4011,13 +4011,6 @@ SourcePositionTable* WasmCompilationUnit::BuildGraphForWasmFunction(
return source_position_table; return source_position_table;
} }
char* WasmCompilationUnit::GetTaggedFunctionName(
const wasm::WasmFunction* function) {
snprintf(function_name_, sizeof(function_name_), "wasm#%d",
function->func_index);
return function_name_;
}
WasmCompilationUnit::WasmCompilationUnit(wasm::ErrorThrower* thrower, WasmCompilationUnit::WasmCompilationUnit(wasm::ErrorThrower* thrower,
Isolate* isolate, Isolate* isolate,
wasm::ModuleBytesEnv* module_env, wasm::ModuleBytesEnv* module_env,
...@@ -4038,7 +4031,7 @@ WasmCompilationUnit::WasmCompilationUnit(wasm::ErrorThrower* thrower, ...@@ -4038,7 +4031,7 @@ WasmCompilationUnit::WasmCompilationUnit(wasm::ErrorThrower* thrower,
compilation_zone_(isolate->allocator(), ZONE_NAME), compilation_zone_(isolate->allocator(), ZONE_NAME),
info_(function->name_length != 0 info_(function->name_length != 0
? module_env->wire_bytes.GetNameOrNull(function) ? module_env->wire_bytes.GetNameOrNull(function)
: CStrVector(GetTaggedFunctionName(function)), : ArrayVector("wasm"),
isolate, &compilation_zone_, isolate, &compilation_zone_,
Code::ComputeFlags(Code::WASM_FUNCTION)), Code::ComputeFlags(Code::WASM_FUNCTION)),
job_(), job_(),
......
...@@ -68,14 +68,11 @@ class WasmCompilationUnit final { ...@@ -68,14 +68,11 @@ class WasmCompilationUnit final {
private: private:
SourcePositionTable* BuildGraphForWasmFunction(double* decode_ms); SourcePositionTable* BuildGraphForWasmFunction(double* decode_ms);
char* GetTaggedFunctionName(const wasm::WasmFunction* function);
wasm::ErrorThrower* thrower_; wasm::ErrorThrower* thrower_;
Isolate* isolate_; Isolate* isolate_;
wasm::ModuleBytesEnv* module_env_; wasm::ModuleBytesEnv* module_env_;
const wasm::WasmFunction* function_; const wasm::WasmFunction* function_;
// Function name is tagged with uint32 func_index - wasm#<func_index>
char function_name_[16];
// The graph zone is deallocated at the end of ExecuteCompilation. // The graph zone is deallocated at the end of ExecuteCompilation.
std::unique_ptr<Zone> graph_zone_; std::unique_ptr<Zone> graph_zone_;
JSGraph* jsgraph_; JSGraph* jsgraph_;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment