Commit 96ae2856 authored by Tobias Tebbi's avatar Tobias Tebbi Committed by Commit Bot

Revert "[csa] CSA type checks: allow the empty FixedArray to be CAST() to FixedDoubleArray"

This reverts commit 60d1277f.

Reason for revert:  This is not sound as long as cast<FixedDoubleArray>() doesn't do the same.

Original change's description:
> [csa] CSA type checks: allow the empty FixedArray to be CAST() to FixedDoubleArray
> 
> This should allow to re-land https://crrev.com/c/1039190
> 
> Bug: chromium:871886
> 
> Change-Id: If815537410b3fa09902026dc26205421f5c36ae5
> Reviewed-on: https://chromium-review.googlesource.com/1169019
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55015}

TBR=jarin@chromium.org,tebbi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:871886
Change-Id: Ib81f3a069776f9e1aa01d16b9d4979de7c56fcde
Reviewed-on: https://chromium-review.googlesource.com/1170742Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55043}
parent 38584fd4
......@@ -1709,11 +1709,6 @@ void CodeAssemblerLabel::UpdateVariablesAfterBind() {
} // namespace compiler
Smi* CheckObjectType(Object* value, Smi* type, String* location) {
// Allow the empty FixedArray to be treated as a FixedDoubleArray.
if (static_cast<ObjectType>(type->value()) == ObjectType::kFixedDoubleArray &&
value->IsFixedArray() && FixedArray::cast(value)->length() == 0) {
return Smi::FromInt(0);
}
#ifdef DEBUG
const char* expected;
switch (static_cast<ObjectType>(type->value())) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment