Commit 8eb261d1 authored by Daniel Bevenius's avatar Daniel Bevenius Committed by Commit Bot

Suppress compiler warning from internal-index.h

This commit adds a static cast to CONSTEXPR_DCHECK in as_int().

The motivation for this is that currently this check generates the
following compiler warning:

/v8/src/objects/internal-index.h: In member function
‘constexpr int v8::internal::InternalIndex::as_int() const’:
/v8/src/objects/internal-index.h:44:29: warning:
comparison of integer expressions of different signedness:
‘const size_t’ {aka ‘const long unsigned int’} and ‘int’ [-Wsign-compare]
   44 |     CONSTEXPR_DCHECK(entry_ <= std::numeric_limits<int>::max());
      |                      ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: I6adda356dbbe522221731a29f205213f1ba23755
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2407892Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69864}
parent 5476ee05
......@@ -40,7 +40,8 @@ class InternalIndex {
return static_cast<uint32_t>(entry_);
}
constexpr int as_int() const {
CONSTEXPR_DCHECK(entry_ <= std::numeric_limits<int>::max());
CONSTEXPR_DCHECK(entry_ <=
static_cast<size_t>(std::numeric_limits<int>::max()));
return static_cast<int>(entry_);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment