Commit 8a173c6f authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

Revert "[nojit] Don't expose wasm in jitless mode"

This reverts commit c79a63e6.

Reason for revert: Needs addtl test skips: https://chromium-review.googlesource.com/c/1470124

Original change's description:
> [nojit] Don't expose wasm in jitless mode
> 
> Wasm currently still creates executable memory even in
> interpreter-only mode, and is thus unsupported in jitless mode. This
> hides wasm completely, which will help e.g. fuzzers that attempt to
> run wasm code (and currently crash on the CHECK in AddOwnedCode).
> 
> Bug: v8:7777,chromium:931068
> Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8
> Reviewed-on: https://chromium-review.googlesource.com/c/1470124
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59561}

TBR=mstarzinger@chromium.org,jgruber@chromium.org

Change-Id: Ic242db3efe73ef362e0f0c3efde90682db6de4a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7777, chromium:931068
Reviewed-on: https://chromium-review.googlesource.com/c/1470131Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59570}
parent 9439a1d2
...@@ -1178,10 +1178,6 @@ DEFINE_NEG_IMPLICATION(jitless, validate_asm) ...@@ -1178,10 +1178,6 @@ DEFINE_NEG_IMPLICATION(jitless, validate_asm)
DEFINE_IMPLICATION(jitless, wasm_interpret_all) DEFINE_IMPLICATION(jitless, wasm_interpret_all)
DEFINE_NEG_IMPLICATION(jitless, asm_wasm_lazy_compilation) DEFINE_NEG_IMPLICATION(jitless, asm_wasm_lazy_compilation)
DEFINE_NEG_IMPLICATION(jitless, wasm_lazy_compilation) DEFINE_NEG_IMPLICATION(jitless, wasm_lazy_compilation)
// Even in interpreter-only mode, wasm currently still creates executable
// memory at runtime. Disable until this changes.
// TODO(jgruber): Remove this once / if wasm can run without executable memory.
DEFINE_NEG_IMPLICATION(jitless, expose_wasm)
// Enable recompilation of function with optimized code. // Enable recompilation of function with optimized code.
DEFINE_BOOL(opt, !V8_LITE_BOOL, "use adaptive optimizations") DEFINE_BOOL(opt, !V8_LITE_BOOL, "use adaptive optimizations")
......
...@@ -528,7 +528,7 @@ ...@@ -528,7 +528,7 @@
'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [SKIP], 'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [SKIP],
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode. # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'test-api/WasmStreaming*': [SKIP], 'test-api/WasmStreamingFinishWithSuccess': [SKIP],
'test-c-wasm-entry/*': [SKIP], 'test-c-wasm-entry/*': [SKIP],
'test-jump-table-assembler/*': [SKIP], 'test-jump-table-assembler/*': [SKIP],
'test-run-wasm-64/*': [SKIP], 'test-run-wasm-64/*': [SKIP],
......
...@@ -364,7 +364,6 @@ ...@@ -364,7 +364,6 @@
'regress/regress-813440': [SKIP], 'regress/regress-813440': [SKIP],
'regress/regress-crbug-746835': [SKIP], 'regress/regress-crbug-746835': [SKIP],
'regress/regress-crbug-772056': [SKIP], 'regress/regress-crbug-772056': [SKIP],
'regress/regress-crbug-816961': [SKIP],
'regress/wasm/*': [SKIP], 'regress/wasm/*': [SKIP],
'tools/compiler-trace-flags': [SKIP], 'tools/compiler-trace-flags': [SKIP],
'wasm/*': [SKIP], 'wasm/*': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment