Commit 880f2fac authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[test] Run tests on all Mac bots in the pool

Dropping the gpu:none dimension broadens the choice of Mac bots from
so far only 8-core VMs to also include 4-core and 12-core Mac Minis.

This CL adjusts the shard configs to account for adding
4-core Mac Minis to the choice.

We also skip a test that's slow only on 4-core bots.

No-Try: true
Bug: chromium:1174040,v8:11418
Change-Id: Ic0be0db197341b7b8f88eb30aa284c38b0e69609
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2685164
Auto-Submit: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72623}
parent 502eea66
...@@ -668,46 +668,42 @@ ...@@ -668,46 +668,42 @@
'swarming_dimensions' : { 'swarming_dimensions' : {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'v8testing', 'shards': 4}, {'name': 'v8testing', 'shards': 8},
], ],
}, },
'v8_mac64_dbg_ng_triggered': { 'v8_mac64_dbg_ng_triggered': {
'swarming_dimensions' : { 'swarming_dimensions' : {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'mozilla'}, {'name': 'mozilla'},
{'name': 'test262', 'variant': 'default', 'shards': 2}, {'name': 'test262', 'variant': 'default', 'shards': 4},
{'name': 'v8testing', 'shards': 3}, {'name': 'v8testing', 'shards': 6},
{'name': 'v8testing', 'variant': 'extra', 'shards': 2}, {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
], ],
}, },
'v8_mac64_gc_stress_dbg_ng_triggered': { 'v8_mac64_gc_stress_dbg_ng_triggered': {
'swarming_dimensions' : { 'swarming_dimensions' : {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 4}, {'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 6},
], ],
}, },
'v8_mac64_rel_ng_triggered': { 'v8_mac64_rel_ng_triggered': {
'swarming_dimensions' : { 'swarming_dimensions' : {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'mozilla'}, {'name': 'mozilla'},
{'name': 'test262', 'variant': 'default', 'shards': 2}, {'name': 'test262', 'variant': 'default', 'shards': 3},
{'name': 'v8testing', 'shards': 2}, {'name': 'v8testing', 'shards': 3},
{'name': 'v8testing', 'variant': 'extra'}, {'name': 'v8testing', 'variant': 'extra', 'shards': 3},
], ],
}, },
'v8_mac_arm64_rel_ng_triggered': { 'v8_mac_arm64_rel_ng_triggered': {
...@@ -1350,46 +1346,42 @@ ...@@ -1350,46 +1346,42 @@
'swarming_dimensions': { 'swarming_dimensions': {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'mozilla'}, {'name': 'mozilla'},
{'name': 'test262', 'variant': 'default', 'shards': 2}, {'name': 'test262', 'variant': 'default', 'shards': 3},
{'name': 'v8testing', 'shards': 2}, {'name': 'v8testing', 'shards': 3},
{'name': 'v8testing', 'variant': 'extra'}, {'name': 'v8testing', 'variant': 'extra', 'shards': 3},
], ],
}, },
'V8 Mac64 - debug': { 'V8 Mac64 - debug': {
'swarming_dimensions': { 'swarming_dimensions': {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'mozilla'}, {'name': 'mozilla'},
{'name': 'test262', 'variant': 'default', 'shards': 2}, {'name': 'test262', 'variant': 'default', 'shards': 4},
{'name': 'v8testing', 'shards': 4}, {'name': 'v8testing', 'shards': 6},
{'name': 'v8testing', 'variant': 'extra', 'shards': 2}, {'name': 'v8testing', 'variant': 'extra', 'shards': 6},
], ],
}, },
'V8 Mac64 ASAN': { 'V8 Mac64 ASAN': {
'swarming_dimensions': { 'swarming_dimensions': {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'v8testing', 'shards': 5}, {'name': 'v8testing', 'shards': 10},
], ],
}, },
'V8 Mac64 GC Stress': { 'V8 Mac64 GC Stress': {
'swarming_dimensions': { 'swarming_dimensions': {
'cpu': 'x86-64', 'cpu': 'x86-64',
'os': 'Mac-10.15', 'os': 'Mac-10.15',
'gpu': 'none',
}, },
'tests': [ 'tests': [
{'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 4}, {'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 6},
], ],
}, },
'V8 Mac - arm64 - release': { 'V8 Mac - arm64 - release': {
......
...@@ -856,6 +856,14 @@ ...@@ -856,6 +856,14 @@
'wasm/externref-globals-liftoff': [SKIP], 'wasm/externref-globals-liftoff': [SKIP],
}], #'arch == riscv64 and variant == stress-incremental-marking' }], #'arch == riscv64 and variant == stress-incremental-marking'
##############################################################################
['system == macos', {
# TODO(machenbach): These tests are x25 slower on 4-core Mac Minis. They can
# be unskipped as soon as the pools only contain 8-core+ Macs.
'wasm/compare-exchange-stress': [SKIP],
'wasm/compare-exchange64-stress': [SKIP],
}], # 'system == macos'
############################################################################## ##############################################################################
['system == windows', { ['system == windows', {
# Too slow with turbo fan. # Too slow with turbo fan.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment