Commit 81fb2ebb authored by Marja Hölttä's avatar Marja Hölttä Committed by Commit Bot

[compiler] Remove a default branch in a switch

Forgetting to add a new bytecode into the lists in
serializer-in-background-compiler.cc results in a confusing CHECK
failure.

This moves the failure to a discoverable place.

Change-Id: I3e78b4702bfa724748ec8ed3f7f49e0eedc504fc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324246
Commit-Queue: Marja Hölttä <marja@chromium.org>
Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69290}
parent 13d252af
...@@ -86,9 +86,24 @@ namespace compiler { ...@@ -86,9 +86,24 @@ namespace compiler {
V(JumpIfUndefinedOrNullConstant) V(JumpIfUndefinedOrNullConstant)
#define IGNORED_BYTECODE_LIST(V) \ #define IGNORED_BYTECODE_LIST(V) \
V(CallRuntimeForPair) \
V(CollectTypeProfile) \
V(DebugBreak0) \
V(DebugBreak1) \
V(DebugBreak2) \
V(DebugBreak3) \
V(DebugBreak4) \
V(DebugBreak5) \
V(DebugBreak6) \
V(DebugBreakExtraWide) \
V(DebugBreakWide) \
V(Debugger) \
V(IncBlockCounter) \ V(IncBlockCounter) \
V(ResumeGenerator) \
V(SuspendGenerator) \
V(ThrowSuperAlreadyCalledIfNotHole) \ V(ThrowSuperAlreadyCalledIfNotHole) \
V(ThrowSuperNotCalledIfHole) V(ThrowSuperNotCalledIfHole) \
V(ToObject)
#define UNREACHABLE_BYTECODE_LIST(V) \ #define UNREACHABLE_BYTECODE_LIST(V) \
V(ExtraWide) \ V(ExtraWide) \
...@@ -1299,8 +1314,6 @@ void SerializerForBackgroundCompilation::TraverseBytecode() { ...@@ -1299,8 +1314,6 @@ void SerializerForBackgroundCompilation::TraverseBytecode() {
break; break;
SUPPORTED_BYTECODE_LIST(DEFINE_BYTECODE_CASE) SUPPORTED_BYTECODE_LIST(DEFINE_BYTECODE_CASE)
#undef DEFINE_BYTECODE_CASE #undef DEFINE_BYTECODE_CASE
default:
break;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment