Commit 7e8ca1a4 authored by Zhi An Ng's avatar Zhi An Ng Committed by Commit Bot

[x64] Fix disassembly of movd

movd/movq moves from/to 32/64 bit operand to xmm, the disasm was
incorrect printing both operands as xmm.

Was: "movd xmm2,xmm10"
Now: "movd xmm2,r10"
Change-Id: I4061257da763efd3493a3fd5875dc116296e1737
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2585258Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71708}
parent d168b399
...@@ -1899,13 +1899,13 @@ int DisassemblerX64::TwoByteOpcodeInstruction(byte* data) { ...@@ -1899,13 +1899,13 @@ int DisassemblerX64::TwoByteOpcodeInstruction(byte* data) {
} else if (opcode == 0x29) { } else if (opcode == 0x29) {
current += PrintOperands("movapd", XMMOPER_XMMREG_OP_ORDER, current); current += PrintOperands("movapd", XMMOPER_XMMREG_OP_ORDER, current);
} else if (opcode == 0x6E) { } else if (opcode == 0x6E) {
current += PrintOperands(rex_w() ? "movq" : "movd", current += PrintOperands(rex_w() ? "movq" : "movd", XMMREG_OPER_OP_ORDER,
XMMREG_XMMOPER_OP_ORDER, current); current);
} else if (opcode == 0x6F) { } else if (opcode == 0x6F) {
current += PrintOperands("movdqa", XMMREG_XMMOPER_OP_ORDER, current); current += PrintOperands("movdqa", XMMREG_XMMOPER_OP_ORDER, current);
} else if (opcode == 0x7E) { } else if (opcode == 0x7E) {
current += PrintOperands(rex_w() ? "movq" : "movd", current += PrintOperands(rex_w() ? "movq" : "movd", OPER_XMMREG_OP_ORDER,
XMMOPER_XMMREG_OP_ORDER, current); current);
} else if (opcode == 0x7F) { } else if (opcode == 0x7F) {
current += PrintOperands("movdqa", XMMOPER_XMMREG_OP_ORDER, current); current += PrintOperands("movdqa", XMMOPER_XMMREG_OP_ORDER, current);
} else if (opcode == 0xD6) { } else if (opcode == 0xD6) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment