Commit 7b386086 authored by Jakob Gruber's avatar Jakob Gruber Committed by V8 LUCI CQ

[compiler] Remove unused JSFunctionData::function_data_

Bug: v8:7790,v8:12149
Change-Id: I0c23b2c1126b2a950efe848973618407f64afeb7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3132268
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76601}
parent 494da13b
...@@ -609,7 +609,6 @@ class JSFunctionData : public JSObjectData { ...@@ -609,7 +609,6 @@ class JSFunctionData : public JSObjectData {
ObjectData* feedback_cell_ = nullptr; ObjectData* feedback_cell_ = nullptr;
int initial_map_instance_size_with_min_slack_; // Derives from int initial_map_instance_size_with_min_slack_; // Derives from
// prototype_or_initial_map_. // prototype_or_initial_map_.
ObjectData* function_data_ = nullptr;
}; };
class BigIntData : public HeapObjectData { class BigIntData : public HeapObjectData {
...@@ -795,9 +794,6 @@ void JSFunctionData::Cache(JSHeapBroker* broker) { ...@@ -795,9 +794,6 @@ void JSFunctionData::Cache(JSHeapBroker* broker) {
SharedFunctionInfo shared = function->shared(kRelaxedLoad); SharedFunctionInfo shared = function->shared(kRelaxedLoad);
shared_ = broker->GetOrCreateData(shared, kAssumeMemoryFence); shared_ = broker->GetOrCreateData(shared, kAssumeMemoryFence);
function_data_ = broker->GetOrCreateData(shared.function_data(kAcquireLoad),
kAssumeMemoryFence);
if (function->has_prototype_slot()) { if (function->has_prototype_slot()) {
prototype_or_initial_map_ = broker->GetOrCreateData( prototype_or_initial_map_ = broker->GetOrCreateData(
function->prototype_or_initial_map(kAcquireLoad), kAssumeMemoryFence); function->prototype_or_initial_map(kAcquireLoad), kAssumeMemoryFence);
...@@ -866,13 +862,6 @@ bool JSFunctionData::IsConsistentWithHeapState(JSHeapBroker* broker) const { ...@@ -866,13 +862,6 @@ bool JSFunctionData::IsConsistentWithHeapState(JSHeapBroker* broker) const {
CHECK_EQ(*native_context_->object(), f->native_context()); CHECK_EQ(*native_context_->object(), f->native_context());
CHECK_EQ(*shared_->object(), f->shared()); CHECK_EQ(*shared_->object(), f->shared());
if (*function_data_->object() !=
Handle<SharedFunctionInfo>::cast(shared_->object())
->function_data(kAcquireLoad)) {
TRACE_BROKER_MISSING(broker, "JSFunction::function_data");
return false;
}
if (f->has_prototype_slot()) { if (f->has_prototype_slot()) {
if (*prototype_or_initial_map_->object() != if (*prototype_or_initial_map_->object() !=
f->prototype_or_initial_map(kAcquireLoad)) { f->prototype_or_initial_map(kAcquireLoad)) {
......
...@@ -211,9 +211,6 @@ ...@@ -211,9 +211,6 @@
'regress/regress-crbug-941743': [PASS, HEAVY], 'regress/regress-crbug-941743': [PASS, HEAVY],
'regress/regress-crbug-1191886': [PASS, HEAVY], 'regress/regress-crbug-1191886': [PASS, HEAVY],
'wasm/externref-globals': [PASS, HEAVY], 'wasm/externref-globals': [PASS, HEAVY],
# TODO(v8:12149): Unskip once the JSFunctionRef dependency is relaxed.
'interrupt-budget-override': [SKIP],
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment