Commit 79d63a5e authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

[wasm] Remove all implications from --predictable

In predictable mode, we want to execute the same code as otherwise,
modulo timing. Hence remove any implications which change behaviour
(like tier-up or asynchronous compilation).
Note that --predictable is a debugging flag, so the configurations does
not need to "make sense" in production.

R=ahaas@chromium.org

Bug: v8:11848
Change-Id: If74fbacadeb087d977922c41f33fd18738b50ded
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940898
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74973}
parent d55942e4
...@@ -2056,11 +2056,6 @@ DEFINE_IMPLICATION(predictable, single_threaded_gc) ...@@ -2056,11 +2056,6 @@ DEFINE_IMPLICATION(predictable, single_threaded_gc)
DEFINE_NEG_IMPLICATION(predictable, concurrent_recompilation) DEFINE_NEG_IMPLICATION(predictable, concurrent_recompilation)
DEFINE_NEG_IMPLICATION(predictable, compiler_dispatcher) DEFINE_NEG_IMPLICATION(predictable, compiler_dispatcher)
DEFINE_NEG_IMPLICATION(predictable, stress_concurrent_inlining) DEFINE_NEG_IMPLICATION(predictable, stress_concurrent_inlining)
#if V8_ENABLE_WEBASSEMBLY
DEFINE_VALUE_IMPLICATION(predictable, wasm_num_compilation_tasks, 0)
DEFINE_NEG_IMPLICATION(predictable, wasm_async_compilation)
DEFINE_NEG_IMPLICATION(predictable, wasm_tier_up)
#endif // V8_ENABLE_WEBASSEMBLY
DEFINE_BOOL(predictable_gc_schedule, false, DEFINE_BOOL(predictable_gc_schedule, false,
"Predictable garbage collection schedule. Fixes heap growing, " "Predictable garbage collection schedule. Fixes heap growing, "
......
...@@ -81,9 +81,8 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = { ...@@ -81,9 +81,8 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = {
INCOMPATIBLE_FLAGS_PER_BUILD_VARIABLE = { INCOMPATIBLE_FLAGS_PER_BUILD_VARIABLE = {
"lite_mode": ["--no-lazy-feedback-allocation", "--max-semi-space-size=*"] "lite_mode": ["--no-lazy-feedback-allocation", "--max-semi-space-size=*"]
+ INCOMPATIBLE_FLAGS_PER_VARIANT["jitless"], + INCOMPATIBLE_FLAGS_PER_VARIANT["jitless"],
"predictable": ["--liftoff", "--parallel-compile-tasks", "predictable": ["--parallel-compile-tasks",
"--concurrent-recompilation", "--concurrent-recompilation",
"--wasm-num-compilation-tasks=*",
"--stress-concurrent-allocation"], "--stress-concurrent-allocation"],
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment