Commit 77b5390b authored by legendecas's avatar legendecas Committed by Commit Bot

[parser] fix bigint as literal property names precision loss

Bug: v8:10274
Change-Id: Ica2b8873c84001ab8c3877747329eb3c78d3ea5a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2114723
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66886}
parent e92fb6e4
...@@ -2221,7 +2221,7 @@ typename ParserBase<Impl>::ExpressionT ParserBase<Impl>::ParseProperty( ...@@ -2221,7 +2221,7 @@ typename ParserBase<Impl>::ExpressionT ParserBase<Impl>::ParseProperty(
case Token::BIGINT: { case Token::BIGINT: {
Consume(Token::BIGINT); Consume(Token::BIGINT);
prop_info->name = impl()->GetNumberAsSymbol(); prop_info->name = impl()->GetSymbol();
is_array_index = impl()->IsArrayIndex(prop_info->name, &index); is_array_index = impl()->IsArrayIndex(prop_info->name, &index);
break; break;
} }
......
...@@ -3,5 +3,7 @@ ...@@ -3,5 +3,7 @@
// found in the LICENSE file. // found in the LICENSE file.
var { 9007199254740991n: it } = { 9007199254740991n: 1 }; var { 9007199254740991n: it } = { 9007199254740991n: 1 };
assertEquals(it, 1);
var { 999999999999999999n: it } = { 999999999999999999n: 1 }; // greater than max safe integer
assertEquals(it, 1); assertEquals(it, 1);
...@@ -557,10 +557,6 @@ ...@@ -557,10 +557,6 @@
'intl402/DateTimeFormat/invalid-numbering-system-calendar-options': [FAIL], 'intl402/DateTimeFormat/invalid-numbering-system-calendar-options': [FAIL],
'intl402/NumberFormat/invalid-numbering-system-options': [FAIL], 'intl402/NumberFormat/invalid-numbering-system-options': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=10274
# BigInt as literal property names must be valid
'language/expressions/object/literal-property-name-bigint': [FAIL],
######################## NEEDS INVESTIGATION ########################### ######################## NEEDS INVESTIGATION ###########################
# https://bugs.chromium.org/p/v8/issues/detail?id=7833 # https://bugs.chromium.org/p/v8/issues/detail?id=7833
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment