Commit 7683df24 authored by Jochen Eisinger's avatar Jochen Eisinger Committed by Commit Bot

Disable -Werror=attributes on gcc

The warning triggers even if the attributes don't change - it's enough
to declare them multiple times. Given that the other compilers don't
complain, just disable the warning on gcc for now.

R=jkummerow@chromium.org,mtrofin@chromium.org
BUG=v8:6339
NOTRY=true

Change-Id: Ie0fcc4feeb8568d4ab74ac65f6887523f3cdcbf9
Reviewed-on: https://chromium-review.googlesource.com/494106
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45045}
parent 94ca3b68
......@@ -466,6 +466,13 @@ config("toolchain") {
}
}
# This really should be if (is_gcc) {}.
if (!is_clang && (is_linux || is_android)) {
# Suppress warnings about different multiple visibility annotations on
# symbols. See https://crbug.com/v8/6339.
cflags += [ "-Wno-attributes" ]
}
if (is_win) {
cflags += [
"/wd4245", # Conversion with signed/unsigned mismatch.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment