Commit 729d5de6 authored by Andreas Haas's avatar Andreas Haas Committed by Commit Bot

[api] Define TypedArray::kMaxLength in api.cc

Otherwise the value cannot be used in gtests in EXPECT_GT expressions.
The reason is that EXPECT_GT takes values by reference and not by
value, so the declaration in v8.h is not enough.

R=clemensb@chromium.org

Bug: v8:9810
Change-Id: I6f85024d483701fcc65d1ccfc5254dbdbcce16c1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871606Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64482}
parent 434f9681
...@@ -3790,6 +3790,8 @@ void v8::ArrayBufferView::CheckCast(Value* that) { ...@@ -3790,6 +3790,8 @@ void v8::ArrayBufferView::CheckCast(Value* that) {
"Could not convert to ArrayBufferView"); "Could not convert to ArrayBufferView");
} }
constexpr size_t v8::TypedArray::kMaxLength;
void v8::TypedArray::CheckCast(Value* that) { void v8::TypedArray::CheckCast(Value* that) {
i::Handle<i::Object> obj = Utils::OpenHandle(that); i::Handle<i::Object> obj = Utils::OpenHandle(that);
Utils::ApiCheck(obj->IsJSTypedArray(), "v8::TypedArray::Cast()", Utils::ApiCheck(obj->IsJSTypedArray(), "v8::TypedArray::Cast()",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment