Commit 709c906a authored by ivica.bogosavljevic's avatar ivica.bogosavljevic Committed by Commit bot

Fix compilation failure due to overload of virtual function

Compilation failure is result to overloaded-virtual warning
treated as error.

BUG=

Review-Url: https://codereview.chromium.org/2895923002
Cr-Commit-Position: refs/heads/master@{#45525}
parent cd778f13
...@@ -135,6 +135,7 @@ class ShellArrayBufferAllocator : public ArrayBufferAllocatorBase { ...@@ -135,6 +135,7 @@ class ShellArrayBufferAllocator : public ArrayBufferAllocatorBase {
return malloc(length); return malloc(length);
#endif #endif
} }
using ArrayBufferAllocatorBase::Free;
void Free(void* data, size_t length) override { void Free(void* data, size_t length) override {
#if USE_VM #if USE_VM
if (RoundToPageSize(&length)) { if (RoundToPageSize(&length)) {
......
...@@ -37,7 +37,11 @@ class MockArrayBufferAllocator : public v8::ArrayBuffer::Allocator { ...@@ -37,7 +37,11 @@ class MockArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
public: public:
void* Allocate(size_t length) override { return nullptr; } void* Allocate(size_t length) override { return nullptr; }
void* AllocateUninitialized(size_t length) override { return nullptr; } void* AllocateUninitialized(size_t length) override { return nullptr; }
void* Reserve(size_t length) override { return nullptr; }
void Free(void* data, size_t length, AllocationMode mode) override {}
void Free(void* p, size_t) override {} void Free(void* p, size_t) override {}
void SetProtection(void* data, size_t length,
Protection protection) override {}
}; };
static int DumpHeapConstants(const char* argv0) { static int DumpHeapConstants(const char* argv0) {
......
...@@ -1894,7 +1894,11 @@ class OOMArrayBufferAllocator : public ArrayBuffer::Allocator { ...@@ -1894,7 +1894,11 @@ class OOMArrayBufferAllocator : public ArrayBuffer::Allocator {
public: public:
void* Allocate(size_t) override { return nullptr; } void* Allocate(size_t) override { return nullptr; }
void* AllocateUninitialized(size_t) override { return nullptr; } void* AllocateUninitialized(size_t) override { return nullptr; }
void* Reserve(size_t length) override { return nullptr; }
void Free(void* data, size_t length, AllocationMode mode) override {}
void Free(void*, size_t) override {} void Free(void*, size_t) override {}
void SetProtection(void* data, size_t length,
Protection protection) override {}
}; };
TEST_F(ValueSerializerTest, DecodeArrayBufferOOM) { TEST_F(ValueSerializerTest, DecodeArrayBufferOOM) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment