Commit 70429e7a authored by machenbach's avatar machenbach Committed by Commit bot

Reland of [gn] Switch win clang bot to gn (patchset #1 id:1 of...

Reland of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2311853002/ )

Reason for revert:
Trying reland with plugin switched off.

Original issue's description:
> Revert of [gn] Switch win clang bot to gn (patchset #1 id:1 of https://codereview.chromium.org/2310863002/ )
>
> Reason for revert:
> Fails compilation:
> https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang
>
> Original issue's description:
> > [gn] Switch win clang bot to gn
> >
> > BUG=chromium:474921
> > NOTRY=true
> >
> > Committed: https://crrev.com/1740587772bbd1ffb7b79a90deb16519e8d47588
> > Cr-Commit-Position: refs/heads/master@{#39156}
>
> TBR=jochen@chromium.org,vogelheim@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:474921
>
> Committed: https://crrev.com/49e13ea6eab4158915a75b95ccc9f01892924d9e
> Cr-Commit-Position: refs/heads/master@{#39158}

TBR=jochen@chromium.org,vogelheim@chromium.org
NOTRY=true
BUG=chromium:474921,chromium:644096

Review-Url: https://codereview.chromium.org/2312093002
Cr-Commit-Position: refs/heads/master@{#39201}
parent ed8791ea
......@@ -52,7 +52,8 @@
'gn_release_x86_no_snap_shared_minimal_symbols',
'V8 Win64': 'gn_release_x64_minimal_symbols',
'V8 Win64 - debug': 'gn_debug_x64_minimal_symbols',
'V8 Win64 - clang': 'gyp_release_x64_clang',
# TODO(machenbach): Switch plugins on when errors are fixed.
'V8 Win64 - clang': 'gn_release_x64_clang_no_plugins',
# Mac.
'V8 Mac': 'gn_release_x86',
'V8 Mac - debug': 'gn_debug_x86',
......@@ -254,6 +255,8 @@
'gn_release_x64_asan_minimal_symbols': [
'gn', 'release_bot', 'x64', 'asan', 'lsan', 'minimal_symbols',
'swarming'],
'gn_release_x64_clang_no_plugins': [
'gn', 'release_bot', 'x64', 'clang', 'no_plugins', 'swarming'],
'gn_release_x64_internal': [
'gn', 'release_bot', 'x64', 'swarming', 'v8_snapshot_internal'],
'gn_release_x64_minimal_symbols': [
......@@ -385,8 +388,6 @@
'v8_verify_heap'],
'gyp_release_x64_cfi_symbolized': [
'gyp', 'release_bot', 'x64', 'cfi', 'swarming', 'symbolized'],
'gyp_release_x64_clang': [
'gyp', 'release_bot', 'x64', 'clang', 'swarming'],
'gyp_release_x64_gcc_coverage': [
'gyp', 'release_bot', 'x64', 'coverage', 'gcc'],
......@@ -519,6 +520,10 @@
'use_prebuilt_instrumented_libraries=1'),
},
'no_plugins': {
'gn_args': 'clang_use_chrome_plugins=false',
},
'release': {
'gn_args': 'is_debug=false',
},
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment