Commit 6f82da0c authored by Clemens Hammacher's avatar Clemens Hammacher Committed by Commit Bot

[iwyu] Fix raw-machine-assembler.h

Fix by removing a method with a single user instead of introducing an
inl-header.

R=mstarzinger@chromium.org

Bug: v8:7965
Change-Id: I596a673f36c63197db3e774d24b65abe01e83399
Reviewed-on: https://chromium-review.googlesource.com/c/1303717
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57071}
parent 2a413f82
...@@ -296,7 +296,9 @@ TNode<String> CodeAssembler::StringConstant(const char* str) { ...@@ -296,7 +296,9 @@ TNode<String> CodeAssembler::StringConstant(const char* str) {
} }
TNode<Oddball> CodeAssembler::BooleanConstant(bool value) { TNode<Oddball> CodeAssembler::BooleanConstant(bool value) {
return UncheckedCast<Oddball>(raw_assembler()->BooleanConstant(value)); Handle<Object> object = isolate()->factory()->ToBoolean(value);
return UncheckedCast<Oddball>(
raw_assembler()->HeapConstant(Handle<HeapObject>::cast(object)));
} }
TNode<ExternalReference> CodeAssembler::ExternalConstant( TNode<ExternalReference> CodeAssembler::ExternalConstant(
......
...@@ -100,10 +100,6 @@ class V8_EXPORT_PRIVATE RawMachineAssembler { ...@@ -100,10 +100,6 @@ class V8_EXPORT_PRIVATE RawMachineAssembler {
Node* HeapConstant(Handle<HeapObject> object) { Node* HeapConstant(Handle<HeapObject> object) {
return AddNode(common()->HeapConstant(object)); return AddNode(common()->HeapConstant(object));
} }
Node* BooleanConstant(bool value) {
Handle<Object> object = isolate()->factory()->ToBoolean(value);
return HeapConstant(Handle<HeapObject>::cast(object));
}
Node* ExternalConstant(ExternalReference address) { Node* ExternalConstant(ExternalReference address) {
return AddNode(common()->ExternalConstant(address)); return AddNode(common()->ExternalConstant(address));
} }
......
...@@ -30,7 +30,6 @@ AUTO_EXCLUDE = [ ...@@ -30,7 +30,6 @@ AUTO_EXCLUDE = [
'src/flag-definitions.h', 'src/flag-definitions.h',
# blacklist of headers we need to fix (https://crbug.com/v8/7965). # blacklist of headers we need to fix (https://crbug.com/v8/7965).
'src/compiler/js-context-specialization.h', 'src/compiler/js-context-specialization.h',
'src/compiler/raw-machine-assembler.h',
'src/regexp/jsregexp.h', 'src/regexp/jsregexp.h',
'src/snapshot/object-deserializer.h', 'src/snapshot/object-deserializer.h',
'src/transitions.h', 'src/transitions.h',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment