Commit 6de6fdd0 authored by Steve Blackburn's avatar Steve Blackburn Committed by Commit Bot

TODO makes future intentions clear.

This TODO clarifies intentions of 49f60a3b.

Bug: v8:9533
Change-Id: Ide448ae863a8716dafdcdd7fb27801a51655650e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2022145Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Steve Blackburn <steveblackburn@google.com>
Cr-Commit-Position: refs/heads/master@{#65997}
parent 0b596c00
......@@ -56,13 +56,16 @@ Address DeserializerAllocator::AllocateRaw(SnapshotSpace space, int size) {
Address DeserializerAllocator::Allocate(SnapshotSpace space, int size) {
Address address;
HeapObject obj;
if (V8_ENABLE_THIRD_PARTY_HEAP_BOOL) {
AllocationType type = (space == SnapshotSpace::kCode)
? AllocationType::kCode
: AllocationType::kYoung;
return heap_->DeserializerAllocate(type, size);
}
// TODO(steveblackburn) The following logic and AllocateRaw() above should
// be lifted into Heap, pushing the logic to heap_->DeserializerAllocate().
// The implementation below and AllocateRaw() above leak heap abstractions
// such as particular structure of heap spaces.
if (next_alignment_ != kWordAligned) {
const int reserved = size + Heap::GetMaximumFillToAlign(next_alignment_);
address = AllocateRaw(space, reserved);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment