Commit 6dca60ed authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

[wasm] Fix missing break in {NativeModuleDeserializer}.

R=clemensh@chromium.org

Change-Id: I84788f60f531c2faeadad74987ac7af72db10cc0
Reviewed-on: https://chromium-review.googlesource.com/859778Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50479}
parent 1b49f725
...@@ -620,13 +620,15 @@ bool NativeModuleDeserializer::ReadCode() { ...@@ -620,13 +620,15 @@ bool NativeModuleDeserializer::ReadCode() {
// We only expect {undefined}. We check for that when we add code. // We only expect {undefined}. We check for that when we add code.
iter.rinfo()->set_target_object(isolate_->heap()->undefined_value(), iter.rinfo()->set_target_object(isolate_->heap()->undefined_value(),
SKIP_WRITE_BARRIER); SKIP_WRITE_BARRIER);
break;
} }
case RelocInfo::CODE_TARGET: { case RelocInfo::CODE_TARGET: {
uint32_t tag = GetWasmCalleeTag(iter.rinfo()); uint32_t tag = GetWasmCalleeTag(iter.rinfo());
Address target = GetTrampolineOrStubFromTag(tag); Address target = GetTrampolineOrStubFromTag(tag);
iter.rinfo()->set_target_address(nullptr, target, SKIP_WRITE_BARRIER, iter.rinfo()->set_target_address(nullptr, target, SKIP_WRITE_BARRIER,
SKIP_ICACHE_FLUSH); SKIP_ICACHE_FLUSH);
} break; break;
}
case RelocInfo::RUNTIME_ENTRY: { case RelocInfo::RUNTIME_ENTRY: {
uint32_t orig_target = static_cast<uint32_t>( uint32_t orig_target = static_cast<uint32_t>(
reinterpret_cast<intptr_t>(iter.rinfo()->target_address())); reinterpret_cast<intptr_t>(iter.rinfo()->target_address()));
...@@ -634,7 +636,8 @@ bool NativeModuleDeserializer::ReadCode() { ...@@ -634,7 +636,8 @@ bool NativeModuleDeserializer::ReadCode() {
ExternalReferenceTable::instance(isolate_)->address(orig_target); ExternalReferenceTable::instance(isolate_)->address(orig_target);
iter.rinfo()->set_target_runtime_entry( iter.rinfo()->set_target_runtime_entry(
nullptr, address, SKIP_WRITE_BARRIER, SKIP_ICACHE_FLUSH); nullptr, address, SKIP_WRITE_BARRIER, SKIP_ICACHE_FLUSH);
} break; break;
}
default: default:
break; break;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment