Commit 6d8a7e98 authored by Seth Brenith's avatar Seth Brenith Committed by Commit Bot

[tools] skip code_space in mkgrokdump

The pointer to the first page of code space is not consistent and
therefore shouldn't be included in the mkgrokdump output.

No-Tree-Checks: true
Bug: v8:9844
Change-Id: I697c34e30e9b67b44e603e92d4bd3c7b81c1af3c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1856511
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64250}
parent 947a124e
...@@ -185,6 +185,10 @@ static int DumpHeapConstants(FILE* out, const char* argv0) { ...@@ -185,6 +185,10 @@ static int DumpHeapConstants(FILE* out, const char* argv0) {
i::PrintF(out, "HEAP_FIRST_PAGES = {\n"); i::PrintF(out, "HEAP_FIRST_PAGES = {\n");
i::PagedSpaceIterator it(heap); i::PagedSpaceIterator it(heap);
for (i::PagedSpace* s = it.Next(); s != nullptr; s = it.Next()) { for (i::PagedSpace* s = it.Next(); s != nullptr; s = it.Next()) {
// Code page is different on Windows vs Linux (bug v8:9844), so skip it.
if (s->identity() == i::CODE_SPACE) {
continue;
}
DumpSpaceFirstPageAddress(out, s); DumpSpaceFirstPageAddress(out, s);
} }
DumpSpaceFirstPageAddress(out, read_only_heap->read_only_space()); DumpSpaceFirstPageAddress(out, read_only_heap->read_only_space());
......
...@@ -427,7 +427,6 @@ KNOWN_OBJECTS = { ...@@ -427,7 +427,6 @@ KNOWN_OBJECTS = {
# Lower 32 bits of first page addresses for various heap spaces. # Lower 32 bits of first page addresses for various heap spaces.
HEAP_FIRST_PAGES = { HEAP_FIRST_PAGES = {
0x08180000: "old_space", 0x08180000: "old_space",
0x00040000: "code_space",
0x081c0000: "map_space", 0x081c0000: "map_space",
0x08040000: "read_only_space", 0x08040000: "read_only_space",
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment