Commit 6a5d01f9 authored by Marja Hölttä's avatar Marja Hölttä Committed by Commit Bot

[in-place weak refs] Fix inconsistent MaybeObject function naming.

BUG=v8:7308

Change-Id: Ibbb224cc6be69f769158b3c1ea3411ceec8301a9
Reviewed-on: https://chromium-review.googlesource.com/968923Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52096}
parent 4f506dbe
...@@ -126,7 +126,7 @@ Code* FeedbackVector::optimized_code() const { ...@@ -126,7 +126,7 @@ Code* FeedbackVector::optimized_code() const {
OptimizationMarker FeedbackVector::optimization_marker() const { OptimizationMarker FeedbackVector::optimization_marker() const {
MaybeObject* slot = optimized_code_weak_or_smi(); MaybeObject* slot = optimized_code_weak_or_smi();
Smi* value; Smi* value;
if (!slot->IsSmi(&value)) return OptimizationMarker::kNone; if (!slot->ToSmi(&value)) return OptimizationMarker::kNone;
return static_cast<OptimizationMarker>(value->value()); return static_cast<OptimizationMarker>(value->value());
} }
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
namespace v8 { namespace v8 {
namespace internal { namespace internal {
bool MaybeObject::IsSmi(Smi** value) { bool MaybeObject::ToSmi(Smi** value) {
if (HAS_SMI_TAG(this)) { if (HAS_SMI_TAG(this)) {
*value = Smi::cast(reinterpret_cast<Object*>(this)); *value = Smi::cast(reinterpret_cast<Object*>(this));
return true; return true;
......
...@@ -20,7 +20,7 @@ class Smi; ...@@ -20,7 +20,7 @@ class Smi;
class MaybeObject { class MaybeObject {
public: public:
bool IsSmi() const { return HAS_SMI_TAG(this); } bool IsSmi() const { return HAS_SMI_TAG(this); }
inline bool IsSmi(Smi** value); inline bool ToSmi(Smi** value);
bool IsClearedWeakHeapObject() { bool IsClearedWeakHeapObject() {
return ::v8::internal::IsClearedWeakHeapObject(this); return ::v8::internal::IsClearedWeakHeapObject(this);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment