Commit 685e6078 authored by Piotr Sikora's avatar Piotr Sikora Committed by V8 LUCI CQ

[bazel] Use v8_enable_handle_zapping only in debug builds.

This leads to a noticable performance improvements, and this flag
is flipped to "is_debug" by the V8 Autoroller in release branches
for the GN builds, so this change matches that behavior.
Signed-off-by: 's avatarPiotr Sikora <piotrsikora@google.com>
Change-Id: I0a6d9798617939f822a6ce347ed2005b1597627a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3380246Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78561}
parent 5c829be1
...@@ -17,6 +17,7 @@ build:debug --compilation_mode=dbg ...@@ -17,6 +17,7 @@ build:debug --compilation_mode=dbg
build:debug --config=v8_enable_debugging_features build:debug --config=v8_enable_debugging_features
build:debug --//:v8_enable_fast_mksnapshot build:debug --//:v8_enable_fast_mksnapshot
build:debug --//:v8_enable_backtrace build:debug --//:v8_enable_backtrace
build:debug --//:v8_enable_handle_zapping
# v8_enable_debugging_features flags # v8_enable_debugging_features flags
build:v8_enable_debugging_features --//:v8_enable_verify_heap build:v8_enable_debugging_features --//:v8_enable_verify_heap
......
...@@ -104,10 +104,7 @@ v8_flag(name = "v8_enable_debug_code") ...@@ -104,10 +104,7 @@ v8_flag(name = "v8_enable_debug_code")
v8_flag(name = "v8_enable_disassembler") v8_flag(name = "v8_enable_disassembler")
v8_flag( v8_flag(name = "v8_enable_handle_zapping")
name = "v8_enable_handle_zapping",
default = True,
)
v8_flag(name = "v8_enable_hugepage") v8_flag(name = "v8_enable_hugepage")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment