Commit 67234388 authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

[API] Deprecate LegacyOOMErrorCallback

Deprecate the LegacyOOMErrorCallback in the 10.5 branch. Embedders are
expected to switch to OOMErrorCallback.
The deprecated LegacyOOMErrorCallback will then be removed in the 10.6
branch.

R=mlippautz@chromium.org

Bug: chromium:1323177
Change-Id: I83001bec760848ef39f0638ed5c5c9eaa7cdb6eb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3646014Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81092}
parent de56e529
...@@ -216,7 +216,7 @@ using AddHistogramSampleCallback = void (*)(void* histogram, int sample); ...@@ -216,7 +216,7 @@ using AddHistogramSampleCallback = void (*)(void* histogram, int sample);
using FatalErrorCallback = void (*)(const char* location, const char* message); using FatalErrorCallback = void (*)(const char* location, const char* message);
using LegacyOOMErrorCallback V8_DEPRECATE_SOON( using LegacyOOMErrorCallback V8_DEPRECATED(
"Use OOMErrorCallback (https://crbug.com/1323177)") = "Use OOMErrorCallback (https://crbug.com/1323177)") =
void (*)(const char* location, bool is_heap_oom); void (*)(const char* location, bool is_heap_oom);
......
...@@ -286,7 +286,7 @@ class V8_EXPORT V8 { ...@@ -286,7 +286,7 @@ class V8_EXPORT V8 {
*/ */
static void SetFatalMemoryErrorCallback(OOMErrorCallback callback); static void SetFatalMemoryErrorCallback(OOMErrorCallback callback);
V8_DEPRECATE_SOON("Use OOMErrorCallback (https://crbug.com/1323177)") V8_DEPRECATED("Use OOMErrorCallback (https://crbug.com/1323177)")
static void SetFatalMemoryErrorCallback(LegacyOOMErrorCallback callback); static void SetFatalMemoryErrorCallback(LegacyOOMErrorCallback callback);
/** /**
......
...@@ -288,7 +288,7 @@ class V8_EXPORT Isolate { ...@@ -288,7 +288,7 @@ class V8_EXPORT Isolate {
FatalErrorCallback fatal_error_callback = nullptr; FatalErrorCallback fatal_error_callback = nullptr;
OOMErrorCallback oom_error_callback = nullptr; OOMErrorCallback oom_error_callback = nullptr;
V8_DEPRECATE_SOON("Use oom_error_callback (https://crbug.com/1323177)") V8_DEPRECATED("Use oom_error_callback (https://crbug.com/1323177)")
LegacyOOMErrorCallback legacy_oom_error_callback = nullptr; LegacyOOMErrorCallback legacy_oom_error_callback = nullptr;
/** /**
...@@ -1469,7 +1469,7 @@ class V8_EXPORT Isolate { ...@@ -1469,7 +1469,7 @@ class V8_EXPORT Isolate {
void SetFatalErrorHandler(FatalErrorCallback that); void SetFatalErrorHandler(FatalErrorCallback that);
/** Set the callback to invoke in case of OOM errors (deprecated). */ /** Set the callback to invoke in case of OOM errors (deprecated). */
V8_DEPRECATE_SOON("Use OOMErrorCallback (https://crbug.com/1323177)") V8_DEPRECATED("Use OOMErrorCallback (https://crbug.com/1323177)")
void SetOOMErrorHandler(LegacyOOMErrorCallback that); void SetOOMErrorHandler(LegacyOOMErrorCallback that);
/** Set the callback to invoke in case of OOM errors. */ /** Set the callback to invoke in case of OOM errors. */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment