Commit 66741e4e authored by Eric Seckler's avatar Eric Seckler Committed by Commit Bot

microtask queue: Fix trace event ordering.

The previous ordering caused a SCOPED event to end after its parent
event, which isn't really supported in the trace format.

Change-Id: I2ddaa12596604499366854231506c889d910f951
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741926Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63118}
parent bc7c2604
...@@ -159,10 +159,13 @@ int MicrotaskQueue::RunMicrotasks(Isolate* isolate) { ...@@ -159,10 +159,13 @@ int MicrotaskQueue::RunMicrotasks(Isolate* isolate) {
HandleScopeImplementer::EnteredContextRewindScope rewind_scope( HandleScopeImplementer::EnteredContextRewindScope rewind_scope(
isolate->handle_scope_implementer()); isolate->handle_scope_implementer());
TRACE_EVENT_BEGIN0("v8.execute", "RunMicrotasks"); TRACE_EVENT_BEGIN0("v8.execute", "RunMicrotasks");
TRACE_EVENT_CALL_STATS_SCOPED(isolate, "v8", "V8.RunMicrotasks"); {
maybe_result = Execution::TryRunMicrotasks(isolate, this, &maybe_exception); TRACE_EVENT_CALL_STATS_SCOPED(isolate, "v8", "V8.RunMicrotasks");
processed_microtask_count = maybe_result = Execution::TryRunMicrotasks(isolate, this,
static_cast<int>(finished_microtask_count_ - base_count); &maybe_exception);
processed_microtask_count =
static_cast<int>(finished_microtask_count_ - base_count);
}
TRACE_EVENT_END1("v8.execute", "RunMicrotasks", "microtask_count", TRACE_EVENT_END1("v8.execute", "RunMicrotasks", "microtask_count",
processed_microtask_count); processed_microtask_count);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment