Commit 64378066 authored by machenbach's avatar machenbach Committed by Commit bot

Revert of [inspector] Record EvaluateScript trace event upon console...

Revert of [inspector] Record EvaluateScript trace event upon console evaluation (patchset #2 id:20001 of https://codereview.chromium.org/2413943002/ )

Reason for revert:
Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10647

See also:
https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> [inspector] Record EvaluateScript trace event upon console evaluation
>
> It will allow timeline to show JS profile on code evaluated from console.
>
> BUG=chromium:655430
>
> Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172
> Cr-Commit-Position: refs/heads/master@{#40289}

TBR=caseq@chromium.org,paulirish@chromium.org,dgozman@chromium.org,alph@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:655430

Review-Url: https://codereview.chromium.org/2416213002
Cr-Commit-Position: refs/heads/master@{#40299}
parent ede69cfa
include_rules = [ include_rules = [
"-src", "-src",
"+src/inspector",
"+src/base/atomicops.h", "+src/base/atomicops.h",
"+src/base/macros.h", "+src/base/macros.h",
"+src/base/logging.h", "+src/base/logging.h",
"+src/base/platform/platform.h", "+src/base/platform/platform.h",
"+src/inspector",
"+src/tracing",
] ]
...@@ -41,7 +41,6 @@ ...@@ -41,7 +41,6 @@
#include "src/inspector/v8-inspector-impl.h" #include "src/inspector/v8-inspector-impl.h"
#include "src/inspector/v8-inspector-session-impl.h" #include "src/inspector/v8-inspector-session-impl.h"
#include "src/inspector/v8-stack-trace-impl.h" #include "src/inspector/v8-stack-trace-impl.h"
#include "src/tracing/trace-event.h"
#include "include/v8-inspector.h" #include "include/v8-inspector.h"
...@@ -273,8 +272,6 @@ void V8RuntimeAgentImpl::evaluate( ...@@ -273,8 +272,6 @@ void V8RuntimeAgentImpl::evaluate(
const Maybe<bool>& generatePreview, const Maybe<bool>& userGesture, const Maybe<bool>& generatePreview, const Maybe<bool>& userGesture,
const Maybe<bool>& awaitPromise, const Maybe<bool>& awaitPromise,
std::unique_ptr<EvaluateCallback> callback) { std::unique_ptr<EvaluateCallback> callback) {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"),
"EvaluateScript");
ErrorString errorString; ErrorString errorString;
int contextId = int contextId =
ensureContext(&errorString, m_inspector, m_session->contextGroupId(), ensureContext(&errorString, m_inspector, m_session->contextGroupId(),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment