[wasm] Avoid allocating a zone for processing protected instructions

By reusing a single vector instead of allocating one per code object,
we can save lots of heap allocations.

R=eholk@chromium.org

Bug: v8:5277
Change-Id: Ia462c97293cd00607d9f2faf29e265ea78d49394
Reviewed-on: https://chromium-review.googlesource.com/686819Reviewed-by: Eric Holk <eholk@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48187}

src/wasm/wasm-module.cc

@@ -312,12 +312,14 @@ Handle<JSArrayBuffer> NewArrayBuffer(Isolate* isolate, size_t size,
 
 void UnpackAndRegisterProtectedInstructions(Isolate* isolate,
                                             Handle<FixedArray> code_table) {
+  DisallowHeapAllocation no_gc;
+  std::vector<trap_handler::ProtectedInstructionData> unpacked;
+
   for (int i = 0; i < code_table->length(); ++i) {
-    Handle<Code> code;
+    Object* maybe_code = code_table->get(i);
     // This is sometimes undefined when we're called from cctests.
-    if (!code_table->GetValue<Code>(isolate, i).ToHandle(&code)) {
-      continue;
-    }
+    if (maybe_code->IsUndefined(isolate)) continue;
+    Code* code = Code::cast(maybe_code);
 
     if (code->kind() != Code::WASM_FUNCTION) {
       continue;
@@ -330,24 +332,23 @@ void UnpackAndRegisterProtectedInstructions(Isolate* isolate,
 
     const intptr_t base = reinterpret_cast<intptr_t>(code->entry());
 
-    Zone zone(isolate->allocator(), "Wasm Module");
-    ZoneVector<trap_handler::ProtectedInstructionData> unpacked(&zone);
     const int mode_mask =
         RelocInfo::ModeMask(RelocInfo::WASM_PROTECTED_INSTRUCTION_LANDING);
-    for (RelocIterator it(*code, mode_mask); !it.done(); it.next()) {
+    for (RelocIterator it(code, mode_mask); !it.done(); it.next()) {
       trap_handler::ProtectedInstructionData data;
       data.instr_offset = it.rinfo()->data();
       data.landing_offset = reinterpret_cast<intptr_t>(it.rinfo()->pc()) - base;
       unpacked.emplace_back(data);
     }
-    if (unpacked.size() > 0) {
-      int size = code->CodeSize();
-      const int index = RegisterHandlerData(reinterpret_cast<void*>(base), size,
-                                            unpacked.size(), &unpacked[0]);
-      // TODO(eholk): if index is negative, fail.
-      DCHECK_LE(0, index);
-      code->set_trap_handler_index(Smi::FromInt(index));
-    }
+    if (unpacked.empty()) continue;
+
+    int size = code->CodeSize();
+    const int index = RegisterHandlerData(reinterpret_cast<void*>(base), size,
+                                          unpacked.size(), &unpacked[0]);
+    unpacked.clear();
+    // TODO(eholk): if index is negative, fail.
+    DCHECK_LE(0, index);
+    code->set_trap_handler_index(Smi::FromInt(index));
   }
 }