Commit 5ef3e899 authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

[jitless] Disable --interpreted-frames-native-stack

... when jitless is enabled to fix fuzzers that pass random flag
combinations.

Bug: chromium:1096168,v8:7777
Change-Id: Ia78c4d9e1256e44c10df2200ecc32067a617d777
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257220
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68458}
parent 03bb3389
...@@ -442,6 +442,11 @@ DEFINE_IMPLICATION(jitless, regexp_interpret_all) ...@@ -442,6 +442,11 @@ DEFINE_IMPLICATION(jitless, regexp_interpret_all)
DEFINE_NEG_IMPLICATION(jitless, validate_asm) DEFINE_NEG_IMPLICATION(jitless, validate_asm)
// --jitless also implies --no-expose-wasm, see InitializeOncePerProcessImpl. // --jitless also implies --no-expose-wasm, see InitializeOncePerProcessImpl.
#ifndef V8_TARGET_ARCH_ARM
// Unsupported on arm. See https://crbug.com/v8/8713.
DEFINE_NEG_IMPLICATION(jitless, interpreted_frames_native_stack)
#endif
// Flags for inline caching and feedback vectors. // Flags for inline caching and feedback vectors.
DEFINE_BOOL(use_ic, true, "use inline caching") DEFINE_BOOL(use_ic, true, "use inline caching")
DEFINE_INT(budget_for_feedback_vector_allocation, 1 * KB, DEFINE_INT(budget_for_feedback_vector_allocation, 1 * KB,
......
...@@ -98,9 +98,7 @@ void V8::InitializeOncePerProcessImpl() { ...@@ -98,9 +98,7 @@ void V8::InitializeOncePerProcessImpl() {
// The --jitless and --interpreted-frames-native-stack flags are incompatible // The --jitless and --interpreted-frames-native-stack flags are incompatible
// since the latter requires code generation while the former prohibits code // since the latter requires code generation while the former prohibits code
// generation. // generation.
CHECK_WITH_MSG(!FLAG_interpreted_frames_native_stack || !FLAG_jitless, CHECK(!FLAG_interpreted_frames_native_stack || !FLAG_jitless);
"The --jitless and --interpreted-frames-native-stack flags "
"are incompatible.");
base::OS::Initialize(FLAG_hard_abort, FLAG_gc_fake_mmap); base::OS::Initialize(FLAG_hard_abort, FLAG_gc_fake_mmap);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment