Commit 5dde281c authored by Georg Neis's avatar Georg Neis Committed by V8 LUCI CQ

[compiler] Fix a few test flakes and reenable the tests

Bug: v8:12173
Change-Id: I2983be9133f8ff4d1740e8eba05a3c29d603dfc3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168270
Auto-Submit: Georg Neis <neis@chromium.org>
Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76939}
parent 649e9113
...@@ -43,6 +43,7 @@ ...@@ -43,6 +43,7 @@
// The call with spread should have been inlined. // The call with spread should have been inlined.
assertFalse(log_got_interpreted); assertFalse(log_got_interpreted);
assertOptimized(foo); assertOptimized(foo);
%PrepareFunctionForOptimization(foo);
// This invalidates the DependOnArrayIteratorProtector and causes deopt. // This invalidates the DependOnArrayIteratorProtector and causes deopt.
Object.defineProperty(Array.prototype, Symbol.iterator, { Object.defineProperty(Array.prototype, Symbol.iterator, {
......
...@@ -38,6 +38,11 @@ function TestMapConstructorEntrySideEffect(ctor) { ...@@ -38,6 +38,11 @@ function TestMapConstructorEntrySideEffect(ctor) {
ctor.prototype.set = originalPrototypeSet; ctor.prototype.set = originalPrototypeSet;
} }
// Forbid inlining these helper functions to avoid deopt surprises.
%NeverOptimizeFunction(assertEquals);
%NeverOptimizeFunction(assertFalse);
%NeverOptimizeFunction(assertTrue);
%PrepareFunctionForOptimization(TestMapConstructorEntrySideEffect); %PrepareFunctionForOptimization(TestMapConstructorEntrySideEffect);
TestMapConstructorEntrySideEffect(Map); TestMapConstructorEntrySideEffect(Map);
TestMapConstructorEntrySideEffect(Map); TestMapConstructorEntrySideEffect(Map);
...@@ -48,6 +53,7 @@ assertOptimized(TestMapConstructorEntrySideEffect); ...@@ -48,6 +53,7 @@ assertOptimized(TestMapConstructorEntrySideEffect);
// This call would deopt // This call would deopt
TestMapConstructorEntrySideEffect(WeakMap); TestMapConstructorEntrySideEffect(WeakMap);
%PrepareFunctionForOptimization(TestMapConstructorEntrySideEffect); %PrepareFunctionForOptimization(TestMapConstructorEntrySideEffect);
TestMapConstructorEntrySideEffect(WeakMap); TestMapConstructorEntrySideEffect(WeakMap);
TestMapConstructorEntrySideEffect(WeakMap); TestMapConstructorEntrySideEffect(WeakMap);
......
...@@ -211,11 +211,6 @@ ...@@ -211,11 +211,6 @@
'regress/regress-crbug-941743': [PASS, HEAVY], 'regress/regress-crbug-941743': [PASS, HEAVY],
'regress/regress-crbug-1191886': [PASS, HEAVY], 'regress/regress-crbug-1191886': [PASS, HEAVY],
'wasm/externref-globals': [PASS, HEAVY], 'wasm/externref-globals': [PASS, HEAVY],
# BUG(v8:12173).
'compiler/call-with-arraylike-or-spread-7': [PASS, FAIL],
'ic-migrated-map-add-when-monomorphic': [PASS, FAIL],
'es6/map-constructor-entry-side-effect2': [PASS, FAIL]
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment